Fix 53003 on room invite sms shown #53240

Kalydosos · 2024-11-28T07:14:26Z

Explanation of Change

Fixed Issues

$ #53003
PROPOSAL: #53003 (comment)

Tests

Launch app
Open a room chat
Invite a phone number via suggestion eg: +919789945670
Send the message
From whisper, tap invite
Tap header -- member
Open the phone number member
Note expensify.sms is not shown with phone number

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android-native.mp4

Android: mWeb Chrome

android_mweb.mp4

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-11-28T07:14:31Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Kalydosos · 2024-11-28T07:22:28Z

will be changing images for android tests

jayeshmangwani · 2024-11-28T07:25:49Z

Thanks for the PR! Please also address the ESLint errors and fix the unit tests.

Kalydosos · 2024-11-28T07:47:19Z

ok, i'm working on it

Kalydosos · 2024-11-28T08:18:39Z

Thanks for the PR! Please also address the ESLint errors and fix the unit tests.

the unit tests said failed seems have passed but they are marked failed, what do you think ?

jayeshmangwani · 2024-11-28T09:23:13Z

the unit tests said failed seems have passed but they are marked failed, what do you think ?

maybe try to merge latest main branch and push again

jayeshmangwani · 2024-11-28T10:35:35Z

@Kalydosos Have you tested all 13 files where you made these changes?

Kalydosos · 2024-11-28T13:21:59Z

@jayeshmangwani the problem with the tests is the 'NO-BREAK SPACE' (U+00A0) character used here

App/src/libs/LocalePhoneNumber.ts

Line 23 in be6468c

number = number.replace(/ /g, '\u00A0');

i will modify the tests to replace spaces inside the static strings by that same character like here

App/tests/unit/ReportUtilsTest.ts

Line 101 in be6468c

expect(participants.at(0)?.displayName).toBe('(833) 240-3627');

jayeshmangwani · 2024-11-29T09:07:09Z

@Kalydosos Lint is failing here, can you please fix it

jayeshmangwani · 2024-11-29T09:17:46Z

the problem with the tests is the 'NO-BREAK SPACE' (U+00A0) character used here

I believe we shouldn't change the tests in this PR, as the failures don't seem to be caused by our changes. Or am I missing something?

Kalydosos · 2024-11-29T12:36:35Z

I believe we shouldn't change the tests in this PR, as the failures don't seem to be caused by our changes. Or am I missing something?

@jayeshmangwani formatPhoneNumber replace simple space characters by no-break space characters (which make sense)

App/src/libs/LocalePhoneNumber.ts

Line 23 in be6468c

number = number.replace(/ /g, '\u00A0');

Kalydosos · 2024-11-29T12:42:00Z

@Kalydosos Lint is failing here, can you please fix it

@jayeshmangwani the current lint failure have to do with the legacy use of withOnyx in some of the files. It is not from our changes. I guess to deploy on staging they will have to skip that test https://github.com/Expensify/App/actions/runs/12071160259/job/33662272975?pr=53240

jayeshmangwani · 2024-12-02T13:22:23Z

src/pages/RoomMemberDetailsPage.tsx

@@ -47,7 +48,7 @@ function RoomMemberDetailsPage({report, route}: RoomMemberDetailsPagePageProps)
    const member = report?.participants?.[accountID];
    const details = personalDetails?.[accountID] ?? ({} as PersonalDetails);
    const fallbackIcon = details.fallbackIcon ?? '';
-    const displayName = details.displayName ?? '';
+    const displayName = formatPhoneNumber(PersonalDetailsUtils.getDisplayNameOrDefault(details));


IMO, this is not needed here. We are already using formatPhoneNumber for displayName. Please let me know if there is any case where we explicitly need to apply formatPhoneNumber to the room member's display name.

@jayeshmangwani i'll check that

@Kalydosos Please keep the discussion either here or on Slack.

ok, got it, i was trying not to pollute the PR with questions about your question, got it

Haha, no problem! Keeping discussion in one place makes things faster, so 😃 .

i will do a new merge with main

@jayeshmangwani i did a test again after the new merge and it's the same result as in the video above

@Kalydosos For me, it’s working fine both with and without using the formatPhoneNumber. I’m not sure why we’re getting different results.

@Kalydosos Please leave the RoomMemberDetailsPage.tsx page as it is with the changes you’ve made; we’ll figure this out later. However, can you please check the other comments? I feel we shouldn’t make changes in a few places that I’ve highlighted.

@jayeshmangwani I made a test again for this one and i still have the same result., any change on your side for this ?

jayeshmangwani · 2024-12-03T09:43:04Z

src/libs/OptionsListUtils.ts

                type: CONST.ICON_TYPE_AVATAR,
                id: personalDetail?.accountID,
            },
        ],
        descriptiveText: amountText ?? '',
-        login: personalDetail?.login ?? '',
+        login: LocalePhoneNumber.formatPhoneNumber(personalDetail?.login ?? ''),


Please avoid updating the login here. Instead, we will only update the displayName where it is used to ensure that we do not introduce any regressions.

ok, i did a test on spliting expenses and i agree. It will be good if you can also confirm by a visual test

jayeshmangwani · 2024-12-03T09:44:32Z

src/libs/OptionsListUtils.ts

        icons: [
            {
                source: personalDetail?.avatar ?? FallbackAvatar,
-                name: personalDetail?.login ?? '',
+                name: LocalePhoneNumber.formatPhoneNumber(personalDetail?.login ?? ''),


Is this change necessary here? Instead, we can simply use LocalePhoneNumber.formatPhoneNumber directly where the icons.name key is being used.

same here, i did a test on spliting expenses and i agree. It will be good if you can also confirm by a visual test

luacmartins · 2024-12-06T17:15:32Z

@luacmartins, I’m tagging you here to get your consensus. Please note that in this PR, we are not handling the entire app's usage of displayName. There might still be some pages where users can see the .sms in the phone number.

I think that's ok. Let's address the cases we know of.

jayeshmangwani · 2024-12-09T11:25:26Z

@Kalydosos I have tested the changes, and they look good. I was able to see the .sms at a few places and noticed differences in phone numbers (with and without country code prefixes). I’m adding the testing steps below. Let me know if these issues are fixable in this PR, or if we should report them and create a new issue:

Go to the workspace and invite a user with a phone number. Then, navigate to the #admins room for that workspace. You should see the message: added [email protected] as member in the chat.
Create a new account using a phone number. Then, go to Account -> Contact Method -> Press on the phone number and observe the message.

bug-on-verify.mov

Kalydosos · 2024-12-09T13:30:46Z

@jayeshmangwani sounds good. For the issues i will give it a quick estimate.

jayeshmangwani · 2024-12-09T13:39:42Z

Thanks 🙌

Kalydosos · 2024-12-09T15:13:27Z

@jayeshmangwani for issue 1, i dont really have the same result as you when i follow the steps. Check the image below. Or can you make a video of the detailed steps ? Still i can try and pinpoint the issue at this specific line https://github.com/Kalydosos/App/blob/21da67d809020071722423ff4a93056e6382f150/src/libs/ReportActionsUtils.ts#L1700 but feel free to test it with the steps and let me know if indeed the "email" here can also be a phone number and we can apply the fix

Kalydosos · 2024-12-09T16:16:31Z

@jayeshmangwani for issue2, i identify the error and fix it

jayeshmangwani · 2024-12-09T16:25:43Z

Thanks for making changes, @Kalydosos For issue 1 these are the steps

issue-1.mov

Kalydosos · 2024-12-09T17:45:06Z

@jayeshmangwani issue 1 is also fixed. It requires some extra testing.

Kalydosos · 2024-12-10T18:06:48Z

@jayeshmangwani do you think we could merge soon ? We are having some merging conflicts but anyway testing is priority

jayeshmangwani · 2024-12-10T18:10:50Z

I’m hoping that by tomorrow, I can give a final test and then proceed with the merge

Thanks 🙏

jayeshmangwani · 2024-12-11T20:12:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android.mov

Android: mWeb Chrome

mweb-chrome.mov

iOS: Native

iOS.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

jayeshmangwani

LGTM 🚀

luacmartins

LGTM

OSBotify · 2024-12-12T17:43:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-12-13T16:03:06Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.76-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

Kalydosos added 5 commits November 27, 2024 14:05

fix Expensify#53003 on room invite sms shown

4624eb4

generalize the usage of phone number formatting

f9927db

generalize the usage of phone number formatting

079e8c3

run prettier

b10f5fb

Merge branch 'Expensify:main' into fix-53003-on-room-invite-sms-shown

bd015ed

Kalydosos requested a review from a team as a code owner November 28, 2024 07:14

melvin-bot bot requested review from jayeshmangwani and removed request for a team November 28, 2024 07:14

usememo dependency fix

423332c

Kalydosos added 3 commits November 28, 2024 15:06

update some tests with no-break space character

3e28287

lint update

30912b1

lint update

b004644

Kalydosos added 3 commits November 29, 2024 13:48

Merge branch 'main' into fix-53003-on-room-invite-sms-shown

845de1c

remove an extra formatting

ab4b111

Merge branch 'Expensify:main' into fix-53003-on-room-invite-sms-shown

1c367fe

jayeshmangwani reviewed Dec 2, 2024

View reviewed changes

jayeshmangwani reviewed Dec 3, 2024

View reviewed changes

Kalydosos added 4 commits December 7, 2024 00:48

Merge branch 'main' into fix-53003-on-room-invite-sms-shown

9c25564

resolve conflict on profileavatar

b05d47b

resolve conflict on profileavatar

fa48b45

resolve conflict on profileavatar

21da67d

fix phone number formatting issue

6bdeffb

Merge branch 'Expensify:main' into fix-53003-on-room-invite-sms-shown

953d533

fix phone number formatting issue

b705118

Kalydosos added 3 commits December 10, 2024 18:19

Merge branch 'main' into fix-53003-on-room-invite-sms-shown

135dde6

Merge branch 'Expensify:main' into fix-53003-on-room-invite-sms-shown

fe38203

fix phone number formatting issue

8e43fe1

Kalydosos added 2 commits December 11, 2024 08:33

Merge branch 'main' into fix-53003-on-room-invite-sms-shown

2e8a6ea

fix phone number formatting

d8cf634

jayeshmangwani approved these changes Dec 12, 2024

View reviewed changes

melvin-bot bot requested a review from luacmartins December 12, 2024 13:24

luacmartins approved these changes Dec 12, 2024

View reviewed changes

luacmartins merged commit ff419fe into Expensify:main Dec 12, 2024
17 checks passed

github-actions bot mentioned this pull request Dec 13, 2024

Deploy Checklist: New Expensify 2024-12-13 #54111

Open

52 tasks

Fix 53003 on room invite sms shown #53240

Fix 53003 on room invite sms shown #53240

Conversation

Kalydosos commented Nov 28, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 28, 2024

Kalydosos commented Nov 28, 2024

jayeshmangwani commented Nov 28, 2024

Kalydosos commented Nov 28, 2024

Kalydosos commented Nov 28, 2024

jayeshmangwani commented Nov 28, 2024

jayeshmangwani commented Nov 28, 2024

Kalydosos commented Nov 28, 2024 • edited Loading

jayeshmangwani commented Nov 29, 2024

jayeshmangwani commented Nov 29, 2024

Kalydosos commented Nov 29, 2024 • edited Loading

Kalydosos commented Nov 29, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Kalydosos Dec 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luacmartins commented Dec 6, 2024

jayeshmangwani commented Dec 9, 2024

Kalydosos commented Dec 9, 2024

jayeshmangwani commented Dec 9, 2024

Kalydosos commented Dec 9, 2024 • edited Loading

Kalydosos commented Dec 9, 2024

jayeshmangwani commented Dec 9, 2024

Kalydosos commented Dec 9, 2024

Kalydosos commented Dec 10, 2024

jayeshmangwani commented Dec 10, 2024

jayeshmangwani commented Dec 11, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

jayeshmangwani left a comment

Choose a reason for hiding this comment

luacmartins left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 12, 2024

github-actions bot commented Dec 13, 2024

Kalydosos commented Nov 28, 2024 •

edited

Loading

Kalydosos commented Nov 28, 2024 •

edited

Loading

Kalydosos commented Nov 29, 2024 •

edited

Loading

Kalydosos Dec 3, 2024 •

edited

Loading

Kalydosos commented Dec 9, 2024 •

edited

Loading

jayeshmangwani commented Dec 11, 2024 •

edited

Loading