-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to bulk select cards from the same bank in the Card filter #53389
Add ability to bulk select cards from the same bank in the Card filter #53389
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of these stuff looks ok, although logic is pretty complex 😅
Left some small comments
src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersCardPage.tsx
Outdated
Show resolved
Hide resolved
src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersCardPage.tsx
Outdated
Show resolved
Hide resolved
src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersCardPage.tsx
Outdated
Show resolved
Hide resolved
src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersCardPage.tsx
Outdated
Show resolved
Hide resolved
src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersCardPage.tsx
Outdated
Show resolved
Hide resolved
src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersCardPage.tsx
Outdated
Show resolved
Hide resolved
src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersCardPage.tsx
Outdated
Show resolved
Hide resolved
src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersCardPage.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropped small comments
Screenshots/VideosAndroid: NativeScreen.Recording.2025-01-13.at.8.52.45.PM.movScreen.Recording.2025-01-13.at.12.51.44.AM.movAndroid: mWeb ChromeScreen.Recording.2025-01-13.at.12.53.41.AM.moviOS: NativeSimulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-13.at.20.41.06.mp4Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-13.at.00.34.05.mp4iOS: mWeb SafariSimulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-13.at.00.25.33.mp4MacOS: Chrome / SafariScreen.Recording.2025-01-12.at.11.35.09.PM.1.movScreen.Recording.2025-01-13.at.12.14.34.AM.1.movUploading Screen Recording 2025-01-13 at 8.34.03 PM 1.mov… MacOS: DesktopScreen.Recording.2025-01-12.at.11.35.09.PM.1.movScreen.Recording.2025-01-13.at.8.37.27.PM.mov |
Fixed your comments @rayane-djouah and retested all platforms(sorry for not doing it earlier, but I was pressed for time 😮💨 ) |
Thanks @SzymczakJ! Can you please fix the failing test https://github.com/Expensify/App/actions/runs/12747163990/job/35524677965?pr=53389? |
Didn't see that one, I've just fixed it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tests well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @SzymczakJ we have conflicts now 😞
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.85-0 🚀
|
3 similar comments
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.85-0 🚀
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.85-0 🚀
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.85-0 🚀
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.85-0 🚀
|
@joekaufmanexpensify @luacmartins could this be verified internally? we don't have company cards and domain cards linked.
|
I dont have transactions on all of those but looks good! Screen.Recording.2025-01-15.at.14.29.35.mp4 |
🚀 Deployed to production by https://github.com/mountiny in version: 9.0.85-4 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.0.85-4 🚀
|
Explanation of Change
This PR adds Card feeds secion to Card filter on Search page, which is only visible to workspace admin. With this PR admin will be able to bulk select cards from the same feed.
PR also makes workspace admins see all the cards linked to workspace(taken from
cards_
Onyx key).Card feeds secion is built from workspace feeds(
cards_
Onyx key) and domain feeds which are separeted from cardList object(cardList
Onyx key), because right now New Dot doesn't fully support domain cards and it's the only Onyx object that contains it. Admin cannot see all domain cards yet.Fixed Issues
$ #53231
PROPOSAL: N/A
Tests
Offline tests
QA Steps
Same as tests. Please make sure domain feeds are tested well as I didn't have access to any domain feed.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop