Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to bulk select cards from the same bank in the Card filter #53389

Conversation

SzymczakJ
Copy link
Contributor

@SzymczakJ SzymczakJ commented Dec 2, 2024

Explanation of Change

This PR adds Card feeds secion to Card filter on Search page, which is only visible to workspace admin. With this PR admin will be able to bulk select cards from the same feed.
PR also makes workspace admins see all the cards linked to workspace(taken from cards_ Onyx key).
Card feeds secion is built from workspace feeds(cards_ Onyx key) and domain feeds which are separeted from cardList object(cardList Onyx key), because right now New Dot doesn't fully support domain cards and it's the only Onyx object that contains it. Admin cannot see all domain cards yet.

Fixed Issues

$ #53231
PROPOSAL: N/A

Tests

  1. Test on account that has at least three workspaces with linked expensify cards and three workspaces with linked company cards(both of them with admin permissions) and a few domain cards linked(*I think we can only assign domain cards on staging by adhoc builds so this part only applies to staging testing).
  2. Enter advanced filters on search page and go to card filter.
  3. Try scrolling card filter page, selecting and deselecting individual cards.
  4. Try selecting card feeds and make sure connected cards also get selected.
  5. Try unselecting one of the card feed's individual cards and make sure card feed is also unselected.
  6. Try using input to filter cards.
  7. Make sure that after saving cards are visible on advanced filters page and after showing results also in the search page input.

Offline tests

QA Steps

Same as tests. Please make sure domain feeds are tested well as I didn't have access to any domain feed.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native Screenshot 2025-01-13 at 12 49 51
Android: mWeb Chrome Screenshot 2025-01-13 at 12 58 50
iOS: Native Screenshot 2025-01-13 at 10 54 34
iOS: mWeb Safari Screenshot 2025-01-13 at 10 59 03
MacOS: Chrome / Safari Screenshot 2025-01-13 at 10 56 36
MacOS: Desktop Screenshot 2025-01-13 at 13 01 56

@luacmartins luacmartins self-requested a review December 2, 2024 17:46
@SzymczakJ SzymczakJ changed the title WIP Add ability to bulk select cards from the same bank in the Card filter Add ability to bulk select cards from the same bank in the Card filter Dec 6, 2024
Copy link
Member

@Kicu Kicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these stuff looks ok, although logic is pretty complex 😅
Left some small comments

Copy link
Member

@Kicu Kicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped small comments

tests/unit/Search/buildSubstitutionsMapTest.ts Outdated Show resolved Hide resolved
tests/unit/Search/buildCardFilterDataTest.ts Outdated Show resolved Hide resolved
tests/unit/Search/buildCardFilterDataTest.ts Outdated Show resolved Hide resolved
@rayane-djouah
Copy link
Contributor

rayane-djouah commented Jan 13, 2025

Screenshots/Videos

Android: Native
Screen.Recording.2025-01-13.at.8.52.45.PM.mov
Screen.Recording.2025-01-13.at.12.51.44.AM.mov
Android: mWeb Chrome
Screen.Recording.2025-01-13.at.12.53.41.AM.mov
iOS: Native
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-13.at.20.41.06.mp4
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-13.at.00.34.05.mp4
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-13.at.00.25.33.mp4
MacOS: Chrome / Safari
Screen.Recording.2025-01-12.at.11.35.09.PM.1.mov
Screen.Recording.2025-01-13.at.12.14.34.AM.1.mov

Uploading Screen Recording 2025-01-13 at 8.34.03 PM 1.mov…

MacOS: Desktop
Screen.Recording.2025-01-12.at.11.35.09.PM.1.mov
Screen.Recording.2025-01-13.at.8.37.27.PM.mov

@SzymczakJ
Copy link
Contributor Author

Fixed your comments @rayane-djouah and retested all platforms(sorry for not doing it earlier, but I was pressed for time 😮‍💨 )

@rayane-djouah
Copy link
Contributor

Thanks @SzymczakJ! Can you please fix the failing test https://github.com/Expensify/App/actions/runs/12747163990/job/35524677965?pr=53389?

@SzymczakJ
Copy link
Contributor Author

Didn't see that one, I've just fixed it

Copy link
Contributor

@rayane-djouah rayane-djouah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests well

@melvin-bot melvin-bot bot requested a review from luacmartins January 13, 2025 20:11
luacmartins
luacmartins previously approved these changes Jan 13, 2025
Copy link
Contributor

@luacmartins luacmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @SzymczakJ we have conflicts now 😞

luacmartins
luacmartins previously approved these changes Jan 13, 2025
@luacmartins luacmartins merged commit 23bdb06 into Expensify:main Jan 13, 2025
17 checks passed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Copy link
Contributor

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.85-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 failure ❌

3 similar comments
Copy link
Contributor

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.85-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 failure ❌

Copy link
Contributor

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.85-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 failure ❌

Copy link
Contributor

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.85-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 failure ❌

Copy link
Contributor

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.85-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 cancelled 🔪

@kavimuru
Copy link

kavimuru commented Jan 14, 2025

@joekaufmanexpensify @luacmartins could this be verified internally? we don't have company cards and domain cards linked.

Test on account that has at least three workspaces with linked expensify cards and three workspaces with linked company cards(both of them with admin permissions) and a few domain cards linked(*I think we can only assign domain cards on staging by adhoc builds so this part only applies to staging testing).

@mountiny
Copy link
Contributor

I dont have transactions on all of those but looks good!

Screen.Recording.2025-01-15.at.14.29.35.mp4

Copy link
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.85-4 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 success ✅

Copy link
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.85-4 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 cancelled 🔪
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.