[NoQA] Skip calling specific APIs in the E2E tests #53704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgolen
requested changes
Dec 6, 2024
| @@ -155,6 +155,13 @@ export default function installNetworkInterceptor( | |||
| const options = fetchArgsGetRequestInit(args); | |||
| const headers = getFetchRequestHeadersAsObject(options); | |||
| const url = fetchArgsGetUrl(args); | |||
|
|
|||
| // Don't process these specific API commands because running them over and over again in the tests hammers the server in a bad way. | |||
| if (url.includes('command=OptInToPushNotifications') || url.includes('command=OptOutOfPushNotifications')) { | |||
There was a problem hiding this comment.
Suggested change
| if (url.includes('command=OptInToPushNotifications') || url.includes('command=OptOutOfPushNotifications')) { | |
| if (url.includes('api/OptInToPushNotifications') || url.includes('api/OptOutOfPushNotifications')) { |
Co-authored-by: Tim Golen <[email protected]>
hannojg
changed the title
melvin-bot
bot
requested review from
stitesExpensify
and removed request for
a team
|
@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
tgolen
approved these changes
Dec 6, 2024
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
github-actions
bot
added
the
DeployBlockerCash
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
70 tasks
|
🚀 Deployed to staging by https://github.com/tgolen in version: 9.0.73-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.73-8 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Earlier we had this PR:
but we add the network interception to the wrong place. This moves it to the right one.
Fixed Issues
$
PROPOSAL:
Tests
Run
npm run test:e2e:devand make sure:Offline tests
QA Steps
See testing
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop