-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uploading Approve an Expense images to help site #54264
Conversation
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
@amyevans @johncschuster One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
A preview of your ExpensifyHelp changes have been deployed to https://7f64c478.helpdot.pages.dev ⚡️ |
Screenies look great! 🙌 |
🚀 Deployed to staging by https://github.com/johncschuster in version: 9.0.77-0 🚀
|
Related GH - https://github.com/Expensify/Expensify/issues/438175
Image GH - https://github.com/Expensify/Expensify/issues/445250
Help article - https://help.expensify.com/articles/new-expensify/expenses-&-payments/Approve-expenses
Explanation of Change
Fixed Issues
Uploading images form https://github.com/Expensify/Expensify/issues/445250 into our help site repo
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.