Highlight autocomplete value

package.json

@@ -71,7 +71,7 @@
     "react-compiler-healthcheck": "react-compiler-healthcheck --verbose",
     "react-compiler-healthcheck-test": "react-compiler-healthcheck --verbose &> react-compiler-output.txt",
     "generate-search-parser": "peggy --format es -o src/libs/SearchParser/searchParser.js src/libs/SearchParser/searchParser.peggy src/libs/SearchParser/baseRules.peggy",
-    "generate-autocomplete-parser": "peggy --format es -o src/libs/SearchParser/autocompleteParser.js src/libs/SearchParser/autocompleteParser.peggy src/libs/SearchParser/baseRules.peggy",
+    "generate-autocomplete-parser": "peggy --format es -o src/libs/SearchParser/autocompleteParser.js src/libs/SearchParser/autocompleteParser.peggy src/libs/SearchParser/baseRules.peggy && ./scripts/parser-workletization.sh src/libs/SearchParser/autocompleteParser.js",
     "web:prod": "http-server ./dist --cors"
   },
   "dependencies": {

scripts/parser-workletization.sh

@@ -0,0 +1,22 @@
+#!/bin/bash
+###
+# This script modifies the autocompleteParser.js file to be compatible with worklets.
+# autocompleteParser.js is generated by PeggyJS and uses syntax not supported by worklets.
+# This script runs each time the parser is generated by the `generate-autocomplete-parser` command.
+###
+
+filePath=$1
+
+if [ ! -f "$filePath" ]; then
+    echo "$filePath does not exist."
+    exit 1
+fi
+# shellcheck disable=SC2016
+if awk 'BEGIN { print "\47worklet\47\n\nclass peg\$SyntaxError{}" } 1' "$filePath" | sed 's/function peg\$SyntaxError/function temporary/g' | sed 's/peg$subclass(peg$SyntaxError, Error);//g' > tmp.txt; then
+    mv tmp.txt "$filePath"
+    echo "Successfully updated $filePath"
+else
+    echo "An error occurred while modifying the file."
+    rm -f tmp.txt
+    exit 1
+fi

src/components/Search/SearchPageHeaderInput.tsx

@@ -81,6 +81,7 @@ function SearchPageHeaderInput({queryJSON, children}: SearchPageHeaderInputProps
     const [textInputValue, setTextInputValue] = useState(queryText);
     // The input text that was last used for autocomplete; needed for the SearchRouterList when browsing list via arrow keys
     const [autocompleteQueryValue, setAutocompleteQueryValue] = useState(queryText);
+    const [selection, setSelection] = useState({start: textInputValue.length, end: textInputValue.length});
 
     const [autocompleteSubstitutions, setAutocompleteSubstitutions] = useState<SubstitutionMap>({});
     const [isAutocompleteListVisible, setIsAutocompleteListVisible] = useState(false);
@@ -158,7 +159,9 @@ function SearchPageHeaderInput({queryJSON, children}: SearchPageHeaderInputProps
 
                 if (item.searchItemType === CONST.SEARCH.SEARCH_ROUTER_ITEM_TYPE.AUTOCOMPLETE_SUGGESTION && textInputValue) {
                     const trimmedUserSearchQuery = SearchAutocompleteUtils.getQueryWithoutAutocompletedPart(textInputValue);
-                    onSearchQueryChange(`${trimmedUserSearchQuery}${SearchQueryUtils.sanitizeSearchValue(item.searchQuery)} `);
+                    const newSearchQuery = `${trimmedUserSearchQuery}${SearchQueryUtils.sanitizeSearchValue(item.searchQuery)}\u00A0`;
+                    onSearchQueryChange(newSearchQuery);
+                    setSelection({start: newSearchQuery.length, end: newSearchQuery.length});
 
                     if (item.mapKey && item.autocompleteID) {
                         const substitutions = {...autocompleteSubstitutions, [item.mapKey]: item.autocompleteID};
@@ -189,6 +192,14 @@ function SearchPageHeaderInput({queryJSON, children}: SearchPageHeaderInputProps
         [autocompleteSubstitutions],
     );
 
+    const setTextAndUpdateSelection = useCallback(
+        (text: string) => {
+            setTextInputValue(text);
+            setSelection({start: text.length, end: text.length});
+        },
+        [setSelection, setTextInputValue],
+    );
+
     if (isCannedQuery) {
         const headerIcon = getHeaderContent(type).icon;
 
@@ -267,13 +278,14 @@ function SearchPageHeaderInput({queryJSON, children}: SearchPageHeaderInputProps
                     rightComponent={children}
                     routerListRef={listRef}
                     ref={textInputRef}
+                    selection={selection}
                 />
                 <View style={[styles.mh85vh, !isAutocompleteListVisible && styles.dNone]}>
                     <SearchRouterList
                         autocompleteQueryValue={autocompleteQueryValue}
                         searchQueryItem={searchQueryItem}
                         onListItemPress={onListItemPress}
-                        setTextQuery={setTextInputValue}
+                        setTextQuery={setTextAndUpdateSelection}
                         updateAutocompleteSubstitutions={updateAutocompleteSubstitutions}
                         ref={listRef}
                     />

src/components/Search/SearchRouter/SearchRouter.tsx

@@ -87,6 +87,7 @@ function SearchRouter({onRouterClose, shouldHideInputCaret}: SearchRouterProps)
     const [textInputValue, , setTextInputValue] = useDebouncedState('', 500);
     // The input text that was last used for autocomplete; needed for the SearchRouterList when browsing list via arrow keys
     const [autocompleteQueryValue, setAutocompleteQueryValue] = useState(textInputValue);
+    const [selection, setSelection] = useState({start: textInputValue.length, end: textInputValue.length});
     const [autocompleteSubstitutions, setAutocompleteSubstitutions] = useState<SubstitutionMap>({});
     const textInputRef = useRef<AnimatedTextInputRef>(null);
 
@@ -206,6 +207,14 @@ function SearchRouter({onRouterClose, shouldHideInputCaret}: SearchRouterProps)
         [autocompleteSubstitutions, onRouterClose, setTextInputValue, activeWorkspaceID],
     );
 
+    const setTextAndUpdateSelection = useCallback(
+        (text: string) => {
+            setTextInputValue(text);
+            setSelection({start: text.length, end: text.length});
+        },
+        [setSelection, setTextInputValue],
+    );
+
     const onListItemPress = useCallback(
         (item: OptionData | SearchQueryItem) => {
             if (isSearchQueryItem(item)) {
@@ -215,7 +224,9 @@ function SearchRouter({onRouterClose, shouldHideInputCaret}: SearchRouterProps)
 
                 if (item.searchItemType === CONST.SEARCH.SEARCH_ROUTER_ITEM_TYPE.CONTEXTUAL_SUGGESTION) {
                     const searchQuery = getContextualSearchQuery(item);
-                    onSearchQueryChange(`${searchQuery} `, true);
+                    const newSearchQuery = `${searchQuery}\u00A0`;
+                    onSearchQueryChange(newSearchQuery, true);
+                    setSelection({start: newSearchQuery.length, end: newSearchQuery.length});
 
                     const autocompleteKey = getContextualSearchAutocompleteKey(item);
                     if (autocompleteKey && item.autocompleteID) {
@@ -225,7 +236,9 @@ function SearchRouter({onRouterClose, shouldHideInputCaret}: SearchRouterProps)
                     }
                 } else if (item.searchItemType === CONST.SEARCH.SEARCH_ROUTER_ITEM_TYPE.AUTOCOMPLETE_SUGGESTION && textInputValue) {
                     const trimmedUserSearchQuery = SearchAutocompleteUtils.getQueryWithoutAutocompletedPart(textInputValue);
-                    onSearchQueryChange(`${trimmedUserSearchQuery}${SearchQueryUtils.sanitizeSearchValue(item.searchQuery)} `);
+                    const newSearchQuery = `${trimmedUserSearchQuery}${SearchQueryUtils.sanitizeSearchValue(item.searchQuery)}\u00A0`;
+                    onSearchQueryChange(newSearchQuery);
+                    setSelection({start: newSearchQuery.length, end: newSearchQuery.length});
 
                     if (item.mapKey && item.autocompleteID) {
                         const substitutions = {...autocompleteSubstitutions, [item.mapKey]: item.autocompleteID};
@@ -303,14 +316,15 @@ function SearchRouter({onRouterClose, shouldHideInputCaret}: SearchRouterProps)
                         outerWrapperStyle={[shouldUseNarrowLayout ? styles.mv3 : styles.mv2, shouldUseNarrowLayout ? styles.mh5 : styles.mh2]}
                         wrapperFocusedStyle={[styles.borderColorFocus]}
                         isSearchingForReports={isSearchingForReports}
+                        selection={selection}
                         ref={textInputRef}
                     />
                     <SearchRouterList
                         autocompleteQueryValue={autocompleteQueryValue || textInputValue}
                         searchQueryItem={searchQueryItem}
                         additionalSections={additionalSections}
                         onListItemPress={onListItemPress}
-                        setTextQuery={setTextInputValue}
+                        setTextQuery={setTextAndUpdateSelection}
                         updateAutocompleteSubstitutions={updateAutocompleteSubstitutions}
                         ref={listRef}
                     />

src/components/Search/SearchRouter/SearchRouterInput.tsx → src/components/Search/SearchRouter/SearchRouterInput/index.native.tsx

@@ -1,62 +1,19 @@
-import type {ForwardedRef, ReactNode, RefObject} from 'react';
+import type {ForwardedRef} from 'react';
 import React, {forwardRef, useState} from 'react';
-import type {StyleProp, TextInputProps, ViewStyle} from 'react-native';
 import {View} from 'react-native';
 import FormHelpMessage from '@components/FormHelpMessage';
-import type {SelectionListHandle} from '@components/SelectionList/types';
 import TextInput from '@components/TextInput';
 import type {BaseTextInputRef} from '@components/TextInput/BaseTextInput/types';
+import useCurrentUserPersonalDetails from '@hooks/useCurrentUserPersonalDetails';
 import useLocalize from '@hooks/useLocalize';
 import useNetwork from '@hooks/useNetwork';
 import useThemeStyles from '@hooks/useThemeStyles';
+import {parseForLiveMarkdown} from '@libs/SearchAutocompleteUtils';
 import handleKeyPress from '@libs/SearchInputOnKeyPress';
 import shouldDelayFocus from '@libs/shouldDelayFocus';
 import variables from '@styles/variables';
 import CONST from '@src/CONST';
-
-type SearchRouterInputProps = {
-    /** Value of TextInput */
-    value: string;
-
-    /** Callback to update search in SearchRouter */
-    onSearchQueryChange: (searchTerm: string) => void;
-
-    /** Callback invoked when the user submits the input */
-    onSubmit?: () => void;
-
-    /** SearchRouterList ref for managing TextInput and SearchRouterList focus */
-    routerListRef?: RefObject<SelectionListHandle>;
-
-    /** Whether the input is full width */
-    isFullWidth: boolean;
-
-    /** Whether the input is disabled */
-    disabled?: boolean;
-
-    /** Whether the offline message should be shown */
-    shouldShowOfflineMessage?: boolean;
-
-    /** Callback to call when the input gets focus */
-    onFocus?: () => void;
-
-    /** Callback to call when the input gets blur */
-    onBlur?: () => void;
-
-    /** Any additional styles to apply */
-    wrapperStyle?: StyleProp<ViewStyle>;
-
-    /** Any additional styles to apply when input is focused */
-    wrapperFocusedStyle?: StyleProp<ViewStyle>;
-
-    /** Any additional styles to apply to text input along with FormHelperMessage */
-    outerWrapperStyle?: StyleProp<ViewStyle>;
-
-    /** Component to be displayed on the right */
-    rightComponent?: ReactNode;
-
-    /** Whether the search reports API call is running  */
-    isSearchingForReports?: boolean;
-} & Pick<TextInputProps, 'caretHidden' | 'autoFocus'>;
+import type SearchRouterInputProps from './types';
 
 function SearchRouterInput(
     {
@@ -83,6 +40,7 @@ function SearchRouterInput(
     const {translate} = useLocalize();
     const [isFocused, setIsFocused] = useState<boolean>(false);
     const {isOffline} = useNetwork();
+    const currentUserPersonalDetails = useCurrentUserPersonalDetails();
     const offlineMessage: string = isOffline && shouldShowOfflineMessage ? `${translate('common.youAppearToBeOffline')} ${translate('search.resultsAreLimited')}` : '';
 
     const inputWidth = isFullWidth ? styles.w100 : {width: variables.popoverWidth};
@@ -125,6 +83,13 @@ function SearchRouterInput(
                         isLoading={!!isSearchingForReports}
                         ref={ref}
                         onKeyPress={handleKeyPress(onSubmit)}
+                        isMarkdownEnabled
+                        multiline={false}
+                        parser={(input: string) => {
+                            'worklet';
+
+                            return parseForLiveMarkdown(input, currentUserPersonalDetails.login ?? '', currentUserPersonalDetails.displayName ?? '');
+                        }}
                     />
                 </View>
                 {!!rightComponent && <View style={styles.pr3}>{rightComponent}</View>}

src/components/Search/SearchRouter/SearchRouterInput/index.tsx

@@ -0,0 +1,106 @@
+import type {ForwardedRef} from 'react';
+import React, {forwardRef, useState} from 'react';
+import {View} from 'react-native';
+import FormHelpMessage from '@components/FormHelpMessage';
+import TextInput from '@components/TextInput';
+import type {BaseTextInputRef} from '@components/TextInput/BaseTextInput/types';
+import useCurrentUserPersonalDetails from '@hooks/useCurrentUserPersonalDetails';
+import useLocalize from '@hooks/useLocalize';
+import useNetwork from '@hooks/useNetwork';
+import useThemeStyles from '@hooks/useThemeStyles';
+import {parseForLiveMarkdown} from '@libs/SearchAutocompleteUtils';
+import handleKeyPress from '@libs/SearchInputOnKeyPress';
+import shouldDelayFocus from '@libs/shouldDelayFocus';
+import variables from '@styles/variables';
+import CONST from '@src/CONST';
+import type SearchRouterInputProps from './types';
+
+function SearchRouterInput(
+    {
+        value,
+        onSearchQueryChange,
+        onSubmit = () => {},
+        routerListRef,
+        isFullWidth,
+        disabled = false,
+        shouldShowOfflineMessage = false,
+        autoFocus = true,
+        onFocus,
+        onBlur,
+        caretHidden = false,
+        wrapperStyle,
+        wrapperFocusedStyle,
+        outerWrapperStyle,
+        rightComponent,
+        isSearchingForReports,
+        selection,
+    }: SearchRouterInputProps,
+    ref: ForwardedRef<BaseTextInputRef>,
+) {
+    const styles = useThemeStyles();
+    const {translate} = useLocalize();
+    const [isFocused, setIsFocused] = useState<boolean>(false);
+    const {isOffline} = useNetwork();
+    const currentUserPersonalDetails = useCurrentUserPersonalDetails();
+    const offlineMessage: string = isOffline && shouldShowOfflineMessage ? `${translate('common.youAppearToBeOffline')} ${translate('search.resultsAreLimited')}` : '';
+
+    const inputWidth = isFullWidth ? styles.w100 : {width: variables.popoverWidth};
+
+    return (
+        <View style={[outerWrapperStyle]}>
+            <View style={[styles.flexRow, styles.alignItemsCenter, wrapperStyle ?? styles.searchRouterTextInputContainer, isFocused && wrapperFocusedStyle]}>
+                <View style={styles.flex1}>
+                    <TextInput
+                        testID="search-router-text-input"
+                        value={value}
+                        onChangeText={onSearchQueryChange}
+                        autoFocus={autoFocus}
+                        shouldDelayFocus={shouldDelayFocus}
+                        caretHidden={caretHidden}
+                        loadingSpinnerStyle={[styles.mt0, styles.mr2]}
+                        role={CONST.ROLE.PRESENTATION}
+                        placeholder={translate('search.searchPlaceholder')}
+                        autoCapitalize="none"
+                        autoCorrect={false}
+                        spellCheck={false}
+                        enterKeyHint="search"
+                        accessibilityLabel={translate('search.searchPlaceholder')}
+                        disabled={disabled}
+                        maxLength={CONST.SEARCH_QUERY_LIMIT}
+                        onSubmitEditing={onSubmit}
+                        shouldUseDisabledStyles={false}
+                        textInputContainerStyles={[styles.borderNone, styles.pb0]}
+                        inputStyle={[inputWidth, styles.p3, styles.dFlex, styles.alignItemsCenter]}
+                        onFocus={() => {
+                            setIsFocused(true);
+                            routerListRef?.current?.updateExternalTextInputFocus(true);
+                            onFocus?.();
+                        }}
+                        onBlur={() => {
+                            setIsFocused(false);
+                            routerListRef?.current?.updateExternalTextInputFocus(false);
+                            onBlur?.();
+                        }}
+                        isLoading={!!isSearchingForReports}
+                        ref={ref}
+                        onKeyPress={handleKeyPress(onSubmit)}
+                        isMarkdownEnabled
+                        multiline={false}
+                        parser={(input: string) => parseForLiveMarkdown(input, currentUserPersonalDetails.login ?? '', currentUserPersonalDetails.displayName ?? '')}
+                        selection={selection}
+                    />
+                </View>
+                {!!rightComponent && <View style={styles.pr3}>{rightComponent}</View>}
+            </View>
+            <FormHelpMessage
+                style={styles.ph3}
+                isError={false}
+                message={offlineMessage}
+            />
+        </View>
+    );
+}
+
+SearchRouterInput.displayName = 'SearchRouterInput';
+
+export default forwardRef(SearchRouterInput);

src/components/Search/SearchRouter/SearchRouterInput/types.ts

@@ -0,0 +1,49 @@
+import type {ReactNode, RefObject} from 'react';
+import type {StyleProp, TextInputProps, ViewStyle} from 'react-native';
+import type {SelectionListHandle} from '@components/SelectionList/types';
+
+type SearchRouterInputProps = {
+    /** Value of TextInput */
+    value: string;
+
+    /** Callback to update search in SearchRouter */
+    onSearchQueryChange: (searchTerm: string) => void;
+
+    /** Callback invoked when the user submits the input */
+    onSubmit?: () => void;
+
+    /** SearchRouterList ref for managing TextInput and SearchRouterList focus */
+    routerListRef?: RefObject<SelectionListHandle>;
+
+    /** Whether the input is full width */
+    isFullWidth: boolean;
+
+    /** Whether the input is disabled */
+    disabled?: boolean;
+
+    /** Whether the offline message should be shown */
+    shouldShowOfflineMessage?: boolean;
+
+    /** Callback to call when the input gets focus */
+    onFocus?: () => void;
+
+    /** Callback to call when the input gets blur */
+    onBlur?: () => void;
+
+    /** Any additional styles to apply */
+    wrapperStyle?: StyleProp<ViewStyle>;
+
+    /** Any additional styles to apply when input is focused */
+    wrapperFocusedStyle?: StyleProp<ViewStyle>;
+
+    /** Any additional styles to apply to text input along with FormHelperMessage */
+    outerWrapperStyle?: StyleProp<ViewStyle>;
+
+    /** Component to be displayed on the right */
+    rightComponent?: ReactNode;
+
+    /** Whether the search reports API call is running  */
+    isSearchingForReports?: boolean;
+} & Pick<TextInputProps, 'caretHidden' | 'autoFocus' | 'selection'>;
+
+export default SearchRouterInputProps;

src/components/Search/SearchRouter/SearchRouterList.tsx

@@ -453,7 +453,7 @@ function SearchRouterList(
             }
 
             const trimmedUserSearchQuery = SearchAutocompleteUtils.getQueryWithoutAutocompletedPart(autocompleteQueryValue);
-            setTextQuery(`${trimmedUserSearchQuery}${SearchQueryUtils.sanitizeSearchValue(focusedItem.searchQuery)} `);
+            setTextQuery(`${trimmedUserSearchQuery}${SearchQueryUtils.sanitizeSearchValue(focusedItem.searchQuery)}\u00A0`);
             updateAutocompleteSubstitutions(focusedItem);
         },
         [autocompleteQueryValue, setTextQuery, updateAutocompleteSubstitutions],