[WIP] Align default IDs in IOU.ts file

.eslintrc.changed.js

@@ -12,7 +12,6 @@ module.exports = {
         {
             files: [
                 'src/libs/ReportUtils.ts',
-                'src/libs/actions/IOU.ts',
                 'src/libs/actions/Report.ts',
                 'src/libs/actions/Task.ts',
                 'src/libs/OptionsListUtils.ts',

src/libs/API/parameters/CategorizeTrackedExpenseParams.ts

@@ -6,14 +6,14 @@ type CategorizeTrackedExpenseParams = {
     comment: string;
     created: string;
     merchant: string;
-    policyID: string;
-    transactionID: string;
-    moneyRequestPreviewReportActionID: string;
-    moneyRequestReportID: string;
-    moneyRequestCreatedReportActionID: string;
+    policyID: string | undefined;
+    transactionID: string | undefined;
+    moneyRequestPreviewReportActionID: string | undefined;
+    moneyRequestReportID: string | undefined;
+    moneyRequestCreatedReportActionID: string | undefined;
     actionableWhisperReportActionID: string;
     modifiedExpenseReportActionID: string;
-    reportPreviewReportActionID: string;
+    reportPreviewReportActionID: string | undefined;
     category?: string;
     tag?: string;
     receipt?: Receipt;

src/libs/API/parameters/CompleteSplitBillParams.ts

@@ -1,5 +1,5 @@
 type CompleteSplitBillParams = {
-    transactionID: string;
+    transactionID: string | undefined;
     amount?: number;
     currency?: string;
     created?: string;

src/libs/API/parameters/ConvertTrackedExpenseToRequestParams.ts

@@ -10,10 +10,10 @@ type ConvertTrackedExpenseToRequestParams = {
     chatReportID: string;
     transactionID: string;
     actionableWhisperReportActionID: string;
-    createdChatReportActionID: string;
+    createdChatReportActionID: string | undefined;
     receipt?: Receipt;
     moneyRequestReportID: string;
-    moneyRequestCreatedReportActionID: string;
+    moneyRequestCreatedReportActionID: string | undefined;
     moneyRequestPreviewReportActionID: string;
     reportPreviewReportActionID: string;
 };

src/libs/API/parameters/CreateDistanceRequestParams.ts

@@ -1,7 +1,7 @@
 type CreateDistanceRequestParams = {
     transactionID: string;
     chatReportID: string;
-    createdChatReportActionID: string;
+    createdChatReportActionID: string | undefined;
     reportActionID: string;
     waypoints: string;
     customUnitRateID: string;

src/libs/API/parameters/DeleteMoneyRequestParams.ts

@@ -1,5 +1,5 @@
 type DeleteMoneyRequestParams = {
-    transactionID: string;
+    transactionID: string | undefined;
     reportActionID: string;
 };
 

src/libs/API/parameters/PayMoneyRequestParams.ts

@@ -1,7 +1,7 @@
 import type {PaymentMethodType} from '@src/types/onyx/OriginalMessage';
 
 type PayMoneyRequestParams = {
-    iouReportID: string;
+    iouReportID: string | undefined;
     chatReportID: string;
     reportActionID: string;
     paymentMethodType: PaymentMethodType;

src/libs/API/parameters/RequestMoneyParams.ts

@@ -14,8 +14,8 @@ type RequestMoneyParams = {
     chatReportID: string;
     transactionID: string;
     reportActionID: string;
-    createdChatReportActionID: string;
-    createdIOUReportActionID: string;
+    createdChatReportActionID: string | undefined;
+    createdIOUReportActionID: string | undefined;
     reportPreviewReportActionID: string;
     receipt?: Receipt;
     receiptState?: ValueOf<typeof CONST.IOU.RECEIPT_STATE>;
@@ -26,7 +26,7 @@ type RequestMoneyParams = {
     billable?: boolean;
     receiptGpsPoints?: string;
     transactionThreadReportID: string;
-    createdReportActionIDForThread: string;
+    createdReportActionIDForThread: string | undefined;
     reimbursible?: boolean;
 };
 

src/libs/API/parameters/SendInvoiceParams.ts

@@ -2,7 +2,7 @@ import type {RequireAtLeastOne} from 'type-fest';
 
 type SendInvoiceParams = RequireAtLeastOne<
     {
-        senderWorkspaceID: string;
+        senderWorkspaceID: string | undefined;
         accountID: number;
         receiverEmail?: string;
         receiverInvoiceRoomID?: string;
@@ -21,7 +21,7 @@ type SendInvoiceParams = RequireAtLeastOne<
         companyName?: string;
         companyWebsite?: string;
         createdIOUReportActionID: string;
-        createdReportActionIDForThread: string;
+        createdReportActionIDForThread: string | undefined;
         reportActionID: string;
     },
     'receiverEmail' | 'receiverInvoiceRoomID'

src/libs/API/parameters/SendMoneyParams.ts

@@ -7,11 +7,11 @@ type SendMoneyParams = {
     paymentMethodType: PaymentMethodType;
     transactionID: string;
     newIOUReportDetails: string;
-    createdReportActionID: string;
+    createdReportActionID: string | undefined;
     reportPreviewReportActionID: string;
     createdIOUReportActionID: string;
     transactionThreadReportID: string;
-    createdReportActionIDForThread: string;
+    createdReportActionIDForThread: string | undefined;
 };
 
 export default SendMoneyParams;

src/libs/API/parameters/ShareTrackedExpenseParams.ts

@@ -6,14 +6,14 @@ type ShareTrackedExpenseParams = {
     comment: string;
     created: string;
     merchant: string;
-    policyID: string;
-    transactionID: string;
-    moneyRequestPreviewReportActionID: string;
-    moneyRequestReportID: string;
-    moneyRequestCreatedReportActionID: string;
+    policyID: string | undefined;
+    transactionID: string | undefined;
+    moneyRequestPreviewReportActionID: string | undefined;
+    moneyRequestReportID: string | undefined;
+    moneyRequestCreatedReportActionID: string | undefined;
     actionableWhisperReportActionID: string;
     modifiedExpenseReportActionID: string;
-    reportPreviewReportActionID: string;
+    reportPreviewReportActionID: string | undefined;
     category?: string;
     tag?: string;
     receipt?: Receipt;

src/libs/API/parameters/TrackExpenseParams.ts

@@ -9,10 +9,10 @@ type TrackExpenseParams = {
     created: string;
     merchant: string;
     iouReportID?: string;
-    chatReportID: string;
-    transactionID: string;
-    reportActionID: string;
-    createdChatReportActionID: string;
+    chatReportID: string | undefined;
+    transactionID: string | undefined;
+    reportActionID: string | undefined;
+    createdChatReportActionID: string | undefined;
     createdIOUReportActionID?: string;
     reportPreviewReportActionID?: string;
     receipt?: Receipt;
@@ -23,8 +23,8 @@ type TrackExpenseParams = {
     taxAmount: number;
     billable?: boolean;
     receiptGpsPoints?: string;
-    transactionThreadReportID: string;
-    createdReportActionIDForThread: string;
+    transactionThreadReportID: string | undefined;
+    createdReportActionIDForThread: string | undefined;
     waypoints?: string;
     actionableWhisperReportActionID?: string;
     customUnitRateID?: string;

src/libs/ReportActionsUtils.ts

@@ -771,7 +771,11 @@ function replaceBaseURLInPolicyChangeLogAction(reportAction: ReportAction): Repo
     return updatedReportAction;
 }
 
-function getLastVisibleAction(reportID: string, canUserPerformWriteAction?: boolean, actionsToMerge: Record<string, NullishDeep<ReportAction> | null> = {}): OnyxEntry<ReportAction> {
+function getLastVisibleAction(
+    reportID: string | undefined,
+    canUserPerformWriteAction?: boolean,
+    actionsToMerge: Record<string, NullishDeep<ReportAction> | null> = {},
+): OnyxEntry<ReportAction> {
     let reportActions: Array<ReportAction | null | undefined> = [];
     if (!isEmpty(actionsToMerge)) {
         reportActions = Object.values(fastMerge(allReportActions?.[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportID}`] ?? {}, actionsToMerge ?? {}, true)) as Array<
@@ -801,7 +805,7 @@ function formatLastMessageText(lastMessageText: string) {
 }
 
 function getLastVisibleMessage(
-    reportID: string,
+    reportID: string | undefined,
     canUserPerformWriteAction?: boolean,
     actionsToMerge: Record<string, NullishDeep<ReportAction> | null> = {},
     reportAction: OnyxInputOrEntry<ReportAction> | undefined = undefined,
@@ -1122,7 +1126,7 @@ function doesReportHaveVisibleActions(reportID: string, canUserPerformWriteActio
     return visibleReportActionsWithoutTaskSystemMessage.length > 0;
 }
 
-function getAllReportActions(reportID: string): ReportActions {
+function getAllReportActions(reportID: string | undefined): ReportActions {
     return allReportActions?.[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportID}`] ?? {};
 }
 

src/libs/ReportUtils.ts

@@ -787,7 +787,7 @@ function isDraftReport(reportID: string | undefined): boolean {
 /**
  * Returns the report
  */
-function getReport(reportID: string): OnyxEntry<Report> {
+function getReport(reportID: string | undefined): OnyxEntry<Report> {
     return allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`];
 }
 
@@ -3030,11 +3030,11 @@ function getReportFieldKey(reportFieldId: string) {
 /**
  * Get the report fields attached to the policy given policyID
  */
-function getReportFieldsByPolicyID(policyID: string): Record<string, PolicyReportField> {
+function getReportFieldsByPolicyID(policyID: string | undefined): Record<string, PolicyReportField> {
     const policyReportFields = Object.entries(allPolicies ?? {}).find(([key]) => key.replace(ONYXKEYS.COLLECTION.POLICY, '') === policyID);
     const fieldList = policyReportFields?.[1]?.fieldList;
 
-    if (!policyReportFields || !fieldList) {
+    if (!policyReportFields || !fieldList || !policyID) {
         return {};
     }
 
@@ -4587,7 +4587,7 @@ function buildOptimisticIOUReport(
     payeeAccountID: number,
     payerAccountID: number,
     total: number,
-    chatReportID: string,
+    chatReportID: string | undefined,
     currency: string,
     isSendingMoney = false,
     parentReportActionID?: string,
@@ -4659,7 +4659,14 @@ function populateOptimisticReportFormula(formula: string, report: OptimisticExpe
 }
 
 /** Builds an optimistic invoice report with a randomly generated reportID */
-function buildOptimisticInvoiceReport(chatReportID: string, policyID: string, receiverAccountID: number, receiverName: string, total: number, currency: string): OptimisticExpenseReport {
+function buildOptimisticInvoiceReport(
+    chatReportID: string,
+    policyID: string | undefined,
+    receiverAccountID: number,
+    receiverName: string,
+    total: number,
+    currency: string,
+): OptimisticExpenseReport {
     const formattedTotal = CurrencyUtils.convertToDisplayString(total, currency);
 
     return {
@@ -4729,8 +4736,8 @@ function getExpenseReportStateAndStatus(policy: OnyxEntry<Policy>) {
  * @param parentReportActionID – The parent ReportActionID of the PolicyExpenseChat
  */
 function buildOptimisticExpenseReport(
-    chatReportID: string,
-    policyID: string,
+    chatReportID: string | undefined,
+    policyID: string | undefined,
     payeeAccountID: number,
     total: number,
     currency: string,
@@ -5323,7 +5330,7 @@ function buildOptimisticModifiedExpenseReportAction(
  * @param transactionThreadID - The reportID of the transaction thread
  * @param movedToReportID - The reportID of the report the transaction is moved to
  */
-function buildOptimisticMovedTrackedExpenseModifiedReportAction(transactionThreadID: string, movedToReportID: string): OptimisticModifiedExpenseReportAction {
+function buildOptimisticMovedTrackedExpenseModifiedReportAction(transactionThreadID: string | undefined, movedToReportID: string | undefined): OptimisticModifiedExpenseReportAction {
     const delegateAccountDetails = PersonalDetailsUtils.getPersonalDetailByEmail(delegateEmail);
 
     return {
@@ -6751,7 +6758,7 @@ function getChatByParticipants(newParticipantList: number[], reports: OnyxCollec
 /**
  * Attempts to find an invoice chat report in onyx with the provided policyID and receiverID.
  */
-function getInvoiceChatByParticipants(policyID: string, receiverID: string | number, reports: OnyxCollection<Report> = allReports): OnyxEntry<Report> {
+function getInvoiceChatByParticipants(policyID: string | undefined, receiverID: string | number, reports: OnyxCollection<Report> = allReports): OnyxEntry<Report> {
     return Object.values(reports ?? {}).find((report) => {
         if (!report || !isInvoiceRoom(report) || isArchivedRoom(report)) {
             return false;