Skip to content

Commit

Permalink
Merge pull request #1923 from Expensify/main
Browse files Browse the repository at this point in the history
Update expensify_prod branch
  • Loading branch information
iwiznia authored Oct 28, 2024
2 parents 946e8a8 + 23b1c37 commit 0f4fbf0
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion libstuff/libstuff.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2712,7 +2712,8 @@ int SQuery(sqlite3* db, const char* e, const string& sql, SQResult& result, int6

// We don't warn for constraints errors because sometimes they're allowed, and BedrockCore.cpp will warn for the ones that aren't.
// This prevents creating bugbot issues for the allowed cases. We still log as INFO though so we can diagnose the query with the problem.
if (error == SQLITE_CONSTRAINT) {
// We also don't warn for `interrupt` because it generally means a timeout which is handled separately.
if (error == SQLITE_CONSTRAINT || error == SQLITE_INTERRUPT) {
SINFO("'" << e << "', query failed with error #" << error << " (" << sqlite3_errmsg(db) << "): " << sqlToLog);
} else {
SWARN("'" << e << "', query failed with error #" << error << " (" << sqlite3_errmsg(db) << "): " << sqlToLog);
Expand Down

0 comments on commit 0f4fbf0

Please sign in to comment.