Merge pull request #1992 from Expensify/ionatan_rollbackonreadquery

Rollback transaction on DB plugin read query
Expensify · Dec 2, 2024 · 612f165 · 612f165
2 parents 60731e6 + 5c1ba37
commit 612f165
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/plugins/DB.cpp b/plugins/DB.cpp
@@ -72,6 +72,10 @@ bool BedrockDBCommand::peek(SQLite& db) {
         return false;
     }
 
+    // We rollback here because if we are in a transaction and the querytakes long (which the queries in this command can)
+    // it prevents sqlite from checkpointing and if we accumulate a lot of things to checkpoint, things become slow
+    ((SQLite&) db).rollback();
+
     // Attempt the read-only query
     SQResult result;
     if (!db.read(query, result)) {