Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update expensify_prod branch #1562

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Update expensify_prod branch #1562

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b9524f
Reset '_upgradeCompleted' when we stop leading.
tylerkaraszewski Aug 30, 2023
989c7c0
Non-conditional check
tylerkaraszewski Aug 30, 2023
92a6159
Merge pull request #1561 from Expensify/tyler-reset-upgrade-completed
danieldoglas Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions BedrockServer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,9 @@ void BedrockServer::sync()
}
}

// If we're not leading, we're not upgrading, but we will need to check for upgrades again next time we go leading, so be ready for that.
_upgradeCompleted = false;

// We should give up an any commands, and let them be re-escalated. If commands were initiated locally,
// we can just re-queue them, they will get re-checked once things clear up, and then they'll get
// processed here, or escalated to the new leader. Commands initiated on followers just get dropped,
Expand Down