Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update expensify_prod branch #1566

Merged
merged 23 commits into from
Sep 18, 2023
Merged

Update expensify_prod branch #1566

merged 23 commits into from
Sep 18, 2023

Conversation

rafecolton
Copy link
Member

Will self-merge, this code has already been peer reviewed.

danieldoglas and others added 23 commits August 4, 2023 13:12
@danieldoglas
added new method to get valid peer
387ef4f
@danieldoglas
wip method to runOnValidFollower
6376d7d
@danieldoglas
adding logic to escalate to other followers
3a419c7
@danieldoglas
Merge branch 'main' into dsilva_addingVersionMismatchHandling
9d37cfa
@danieldoglas
adding peer call
30a7aff
@danieldoglas
Merge branch 'main' into dsilva_addingVersionMismatchHandling
125ba22
@danieldoglas
adding tests
4c8cacb
@danieldoglas
making tester a class variable, including new table to test insert
9c70500
@danieldoglas
deploying escalation tests
943d7d8
@danieldoglas
fixing escalation path and tests
90d4a27
@danieldoglas
fix assert
e118417
@danieldoglas
renaming property from nodeName to nodesPath
f2ce01a
@danieldoglas
changing tests from 6 to 5 servers
37f09dd
@danieldoglas
addressing comments
b77d761
@danieldoglas
removing broken code
efc44a0
@danieldoglas
addressing comments, tests don't load test plugin locally
5b02591
@danieldoglas
tests are now passing
a39254b
@danieldoglas
removing unecessary log
dc0732d
@danieldoglas
removing file
2801428
@danieldoglas
fixing log
9bbfe68
@danieldoglas
Merge branches 'dsilva_addingVersionMismatchHandling' and 'dsilva_add…
d7589c6 
…ingVersionMismatchHandling' of github.com:Expensify/Bedrock into dsilva_addingVersionMismatchHandling
@danieldoglas
fixing comment
d613c06
@tylerkaraszewski
Merge pull request #1560 from Expensify/dsilva_addingVersionMismatchH…
828f739 
…andling

Adding version mismatch handling
@melvin-bot
Copy link

melvin-bot bot commented Sep 18, 2023

I see this code uses list. If your primary use case is just checking to see if an item exists in the list, perhaps set is a better choice, as it's much faster for random access. C++ has a variety of data structures available to choose from, so pick the best for your use case.

@rafecolton rafecolton merged commit 673fef3 into expensify_prod Sep 18, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafecolton @danieldoglas @tylerkaraszewski