Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to GH Actions #1760

Merged
merged 7 commits into from
May 31, 2024
Merged

Move to GH Actions #1760

merged 7 commits into from
May 31, 2024

Conversation

johnmlee101
Copy link
Contributor

@johnmlee101 johnmlee101 commented May 31, 2024

Need to test releases, but that requires this be merged.

@johnmlee101 johnmlee101 self-assigned this May 31, 2024
@johnmlee101 johnmlee101 changed the title Move to GH ACtions Move to GH Actions May 31, 2024
- name: Setup tmate session
if: runner.debug == '1'
uses: mxschmitt/action-tmate@v3
timeout-minutes: 60
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems kinda long for a big runner, but maybe we rarely debug?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah we rarely debug, and I haven't seen anyone stretch this as of yet

.github/workflows/bedrock.yml Outdated Show resolved Hide resolved
branches: # this ignores tag pushes, and only looks at branches.
- '**'
release:
types: [prereleased]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because we only trigger pre-releases here: https://github.com/Expensify/Bedrock/releases

@johnmlee101 johnmlee101 merged commit 49b891b into main May 31, 2024
1 check passed
@johnmlee101 johnmlee101 deleted the john-move-to-actions branch May 31, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants