Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SQlite3 #1768

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Update SQlite3 #1768

merged 1 commit into from
Jun 4, 2024

Conversation

johnmlee101
Copy link
Contributor

Details

Fixes a conflict reporting issue

Fixed Issues

https://expensify.slack.com/archives/C0714QF3A1Z/p1717520747775969?thread_ts=1717512172.169249&cid=C0714QF3A1Z

Tests


Internal Testing Reminder: when changing bedrock, please compile auth against your new changes

@johnmlee101 johnmlee101 self-assigned this Jun 4, 2024
@johnmlee101
Copy link
Contributor Author

ran

AMALGAMATION_FLAGS="$(grep 'AMALGAMATION_FLAGS = ' Bedrock/Makefile | awk -F= '{print $2}')"
CLI_FLAGS="-DHAVE_READLINE -O2"
./configure --enable-fts5 --enable-update-limit
make sqlite3.c shell.c

@johnmlee101
Copy link
Contributor Author

running over auth now

@johnmlee101
Copy link
Contributor Author

just realized the flags meant nothing in my run 😂 so

./configure --enable-fts5 --enable-update-limit
make sqlite3.c shell.c

is all that matters

@johnmlee101
Copy link
Contributor Author

✅ PayViaStripeConnectTest::testPaymentToSameAccount (2398ms)
Took 5871ms to stop cluster.

[ TEST RESULTS ] Passed: 3053, Failed: 0

Slowest Test Classes:
361532ms: PayViaStripeConnect
322550ms: WalletMTLFile
321930ms: WalletPayment
315760ms: WalletTransferBalance
314843ms: WalletCustomerMasterFile
314725ms: ValidateBankAccount
313587ms: UpgradeSharedBankAccounts
313573ms: WalletReimbursement
312855ms: ValidateBillingFund
310738ms: WalletLookupFile
./authtest -threads 16  490.45s user 94.57s system 161% cpu 6:02.09 total

@johnmlee101
Copy link
Contributor Author

all tests passed

@tylerkaraszewski tylerkaraszewski merged commit db1d5be into main Jun 4, 2024
1 check passed
@tylerkaraszewski tylerkaraszewski deleted the john-update-sqlite branch June 4, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants