Update sqlite version to include enhanced scanstats #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please close https://github.com/Expensify/Auth/pull/11378 after you merge this. I have to keep https://github.com/Expensify/Auth/pull/11378 open for now or you can't see that all the tests are passing 😄 |
danieldoglas
requested changes
Jun 26, 2024
There was a problem hiding this comment.
This PR is kind of strange, we're only changing the versions in the sqlite3 files. We usually have a change log like this: https://github.com/Expensify/Bedrock/pull/1748/files
|
That looks fine to me. The file that changed is shell.c as you can see here, which we do not include in Bedrock |
danieldoglas
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Update sqlite version to https://sqlite.org/src/info/d826236e22234bd0 with enhanced scanstats.
More explanation here
Fixed Issues
Part of https://github.com/Expensify/Expensify/issues/404202
Tests
Existing unit tests must pass here and in https://github.com/Expensify/Auth/pull/11378
Internal Testing Reminder: when changing bedrock, please compile auth against your new changes