Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly add back deprecated default constructors #1797

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

tylerkaraszewski
Copy link
Contributor

Details

Not having these is deprecated. Certain tools complain.

Fixed Issues

Fixes GH_LINK

Tests


Internal Testing Reminder: when changing bedrock, please compile auth against your new changes

@tylerkaraszewski tylerkaraszewski self-assigned this Jul 4, 2024
@tylerkaraszewski tylerkaraszewski requested a review from bondydaa July 4, 2024 20:00
Copy link
Contributor

@youssef-lr youssef-lr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and fixed the warning for me as well

@youssef-lr youssef-lr merged commit 75f6ee0 into main Jul 5, 2024
1 check passed
@youssef-lr youssef-lr deleted the tyler-implicit-copy-constructors branch July 5, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants