Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add STimestampToEpoch #1810

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Add STimestampToEpoch #1810

merged 2 commits into from
Jul 15, 2024

Conversation

jasperhuangg
Copy link
Contributor

@jasperhuangg jasperhuangg commented Jul 12, 2024

Details

We use this in a few places in Auth so thought I'd add it to Bedrock to DRY things up a bit. See https://github.com/Expensify/Auth/pull/11569/files for more context

Fixed Issues

Related to https://github.com/Expensify/Expensify/issues/410925

Tests

Tested with https://github.com/Expensify/Auth/pull/11569


Internal Testing Reminder: when changing bedrock, please compile auth against your new changes

@jasperhuangg jasperhuangg self-assigned this Jul 12, 2024
@jasperhuangg jasperhuangg changed the title Add STimestampToEpoch Add STimestampToEpoch Jul 12, 2024
@jasperhuangg jasperhuangg marked this pull request as ready for review July 12, 2024 20:49
Copy link
Contributor

@blimpich blimpich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will defer to Tyler for final review though.

@jasperhuangg
Copy link
Contributor Author

Tyler is OOO, gonna move forward with merging

@jasperhuangg jasperhuangg merged commit 7aac1e6 into main Jul 15, 2024
1 check passed
@jasperhuangg jasperhuangg deleted the jasper-addSTimestampToEpoch branch July 15, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants