[HOLD] Allocate all SQLite pool handles on init #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwiznia
approved these changes
Dec 12, 2024
danieldoglas
approved these changes
Dec 12, 2024
flodnv
approved these changes
Dec 12, 2024
|
On my mac: takes 10s |
coleaeason
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
@tylerkaraszewski this causes us to allocate the entirety of a SQLitePool on creation, which for our largest pools is at start up time. We hope this prevents random slow PRAGMAs from starting new handles JIT.
Fixed Issues
https://expensify.slack.com/archives/C07PP7QV8P5/p1733855847062219
Fixes https://github.com/Expensify/Expensify/issues/453048
Tests
Existing. Ran tests, saw expected logs.
Internal Testing Reminder: when changing bedrock, please compile auth against your new changes