Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a build flag to enable shared workflow in react-native-onyx #16

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

AndrewGable
Copy link
Contributor

@AndrewGable AndrewGable commented Oct 17, 2024

Details

  • Adds a should_run_build flag in order to optionally run npm run build for repos that use typescript and require a build step
  • Removes the need to pass in a pull request number and grabs it directly
  • Add a readme to polish the project a bit more

Related Issues

https://github.com/Expensify/Expensify/issues/432173

Tests

  1. Merge this PR
  2. Merge this PR and verify the deploy runs correctly

@AndrewGable AndrewGable self-assigned this Oct 17, 2024
AndrewGable added a commit to Expensify/eslint-config-expensify that referenced this pull request Oct 17, 2024
@AndrewGable AndrewGable merged commit ec64496 into main Oct 17, 2024
1 check passed
@AndrewGable AndrewGable deleted the andrew-onyx branch October 17, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants