Use the shared publish workflow #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@johnmlee101 - We will have to add the |
johnmlee101
reviewed
Oct 10, 2024
.github/workflows/publish.yml
Outdated
| git config --global user.email [email protected] | ||
|
|
||
| - uses: actions/setup-node@v3 | ||
| - uses: Expensify/GitHub-Actions/.github/workflows/npmPublish.yml@main |
There was a problem hiding this comment.
FYI I wonder if we should create versions for this whenever we make code changes in this repo.
There was a problem hiding this comment.
also for testing you can pin it to your branch I think?
There was a problem hiding this comment.
Once I confirm it works, we can tag that commit as 1.0 and update all main references to that 👍
|
|
|
well org with whitelisted repos |
|
Must be holding it wrong: https://github.com/Expensify/eslint-config-expensify/actions/runs/11278808120 |
johnmlee101
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: Expensify/GitHub-Actions#1
Related: https://github.com/Expensify/Expensify/issues/432173