Add check to use periods at the end of error messages #88
Conversation
|
LGTM, will wait for @getusha to take a look |
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "eslint-config-expensify", | |||
| "version": "2.0.44", | |||
| "version": "2.0.45", | |||
There was a problem hiding this comment.
Yes, we need to increase the version and then use it in Expensify/App.
There was a problem hiding this comment.
I don't think that's how it works, check other PRs. that step seems to be automated.
There was a problem hiding this comment.
It's there in above PR. It needs to be done in package-lock.json also, added there as well.
There was a problem hiding this comment.
Got it, OSBotify bot will update it. Updated.
| const lastChar = errorMessage[errorMessage.length - 1]; | ||
| const fixedMessage = lastChar === '.' ? errorMessage : `${errorMessage}.`; |
There was a problem hiding this comment.
i don't see this condition working while having it inside if (!errorMessage.endsWith('.')) {, am i missing anything?
There was a problem hiding this comment.
Yes, the check was not needed. Updated it.
ShridharGoel
force-pushed
the
38989
branch
2 times, most recently
from
6ceb331 to
c695980
Compare
|
@ShridharGoel conflicts |
|
@grgia Updated. |
|
Sorry for the delay, i'll test it today. |
|
🚀 Published in 2.0.46 |
|
Whoops sorry @getusha I thought that you had approved ad merged too early |
Expensify/App#38989