Merge pull request #741 from ahmedGaber93/update-html-mention-rules

update htmlToMarkdownRules userMention and reportMention
Expensify · Jul 5, 2024 · 14cc4dd · 14cc4dd
2 parents 2610f15 + b0e752c
commit 14cc4dd
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/__tests__/ExpensiMark-Markdown-test.js b/__tests__/ExpensiMark-Markdown-test.js
@@ -786,6 +786,9 @@ test('Mention user html to markdown', () => {
 
     testString = '<mention-user accountID="1234" />';
     expect(parser.htmlToMarkdown(testString, extras)).toBe('@[email protected]');
+
+    testString = '<mention-user accountID="1234"></mention-user>';
+    expect(parser.htmlToMarkdown(testString, extras)).toBe('@[email protected]');
 });
 
 test('Mention report html to markdown', () => {
@@ -815,6 +818,9 @@ test('Mention report html to markdown', () => {
 
     testString = '<mention-report reportID="1234" />';
     expect(parser.htmlToMarkdown(testString, extras)).toBe('#room-name');
+
+    testString = '<mention-report reportID="1234"></mention-report>';
+    expect(parser.htmlToMarkdown(testString, extras)).toBe('#room-name');
 });
 
 describe('Image tag conversion to markdown', () => {

diff --git a/lib/ExpensiMark.ts b/lib/ExpensiMark.ts
@@ -647,7 +647,7 @@ export default class ExpensiMark {
 
             {
                 name: 'reportMentions',
-                regex: /<mention-report reportID="(\d+)" *\/>/gi,
+                regex: /<mention-report reportID="(\d+)"(?: *\/>|><\/mention-report>)/gi,
                 replacement: (extras, _match, g1, _offset, _string) => {
                     const reportToNameMap = extras.reportIDToName;
                     if (!reportToNameMap || !reportToNameMap[g1]) {
@@ -660,7 +660,7 @@ export default class ExpensiMark {
             },
             {
                 name: 'userMention',
-                regex: /(?:<mention-user accountID="(\d+)" *\/>)|(?:<mention-user>(.*?)<\/mention-user>)/gi,
+                regex: /(?:<mention-user accountID="(\d+)"(?: *\/>|><\/mention-user>))|(?:<mention-user>(.*?)<\/mention-user>)/gi,
                 replacement: (extras, _match, g1, g2, _offset, _string) => {
                     if (g1) {
                         const accountToNameMap = extras.accountIDToName;