Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edit to remove link not working #585

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

eh2077
Copy link
Contributor

@eh2077 eh2077 commented Oct 7, 2023

Fixed Issues

$ Expensify/App#28344

Tests

  1. Go to a chat and add link like
https://www.google.com
  1. Edit the link from
[https://www.google.com](https://www.google.com)

to

https://www.google.com
  1. Save it and verify that link, https://www.google.com, is displayed as plain text
Screen.Recording.2023-10-06.at.5.44.24.PM.mov

QA

Same as tests

@eh2077 eh2077 requested a review from a team as a code owner October 7, 2023 12:22
@melvin-bot melvin-bot bot requested review from hayata-suenaga and removed request for a team October 7, 2023 12:23
Copy link

@hoangzinh hoangzinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hoangzinh
Copy link

cc @lakchote, all is yours

@hayata-suenaga hayata-suenaga requested review from lakchote and removed request for hayata-suenaga October 9, 2023 01:40
@eh2077
Copy link
Contributor Author

eh2077 commented Oct 9, 2023

@lakchote Can you help to merge the PR? So that I can get the hash to bump version for the App. Thanks!

@lakchote lakchote merged commit 009c2ab into Expensify:main Oct 9, 2023
3 checks passed
@lakchote
Copy link
Contributor

lakchote commented Oct 9, 2023

@eh2077 done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants