Acknowledge CRLF as possible EOL sequence for codefence #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tienifr
changed the title
50 tasks
6 tasks
|
@tienifr Seems like we have ESLint error. Pls fix it |
|
@DylanDylann Are you sure? All checks have passed on my side.
|
|
@tienifr I mean ESLint error here. These tests above don't cover ESLint error 
|
|
That line is unrelated to the code changes made in this PR, is it not? |
|
@blimpich @DylanDylann yes that's not from my PR. |
|
Alright, @johnmlee101 Can you help review this PR? Thanks |
|
Hmm? What's the issue? |
|
@johnmlee101 This one Expensify/App#38001. You might forget the linked issue in PR description😄 |
johnmlee101
approved these changes
Mar 26, 2024
Can't merge @tienifr
|
Snyk has created this PR to upgrade @babel/preset-env from 7.23.9 to 7.24.0. See this package in npm: https://www.npmjs.com/package/@babel/preset-env See this project in Snyk: https://app.snyk.io/org/expensify/project/4945ebcf-d145-4524-893a-d9c905019a72?utm_source=github&utm_medium=referral&page=upgrade-pr
|
@johnmlee101 I've signed previous commits. We're good to go. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The back-end uses CRLF (
\r\n) as EOL sequence for task description (reference here). In our parser, we only acknowledge LF (\n) as a possible EOL after 3 backticks fence, if it's not there, we'll append new line, this leads to a new line being added each time we edit task description.Fixed Issues
$ Expensify/App#38001
Tests
1. What unit/integration tests cover your change? What autoQA tests cover your change?
The
ExpensiMark-HTML-test.jsis updated to include the new test cases.2. What tests did you perform that validates your changed worked?
QA
1. What does QA need to do to validate your changes?
Test in Expensify App follow these steps:
2. What areas to they need to test for regressions?
NA
Screenshots
Screen.Recording.2024-03-25.at.16.17.31-compressed.mov