Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix LHN preview shows incorrect message with attachment #679

Merged
merged 2 commits into from
Apr 12, 2024
Merged

fix LHN preview shows incorrect message with attachment #679

merged 2 commits into from
Apr 12, 2024

Conversation

nkdengineer
Copy link
Contributor

@nkdengineer nkdengineer commented Apr 8, 2024 •
edited
Loading

Fixed Issues

$ Expensify/App#38877

Tests

  1. What unit/integration tests cover your change? What autoQA tests cover your change?
  2. What tests did you perform that validates your changed worked?

QA

  1. Go to staging.new.expensify.com
  2. Go to any chat
  3. Send a message with inline image markdown. Example:
An inline image and some text ![off](https://images.unsplash.com/photo-1709983723739-d72ea88434dd?q=80&w=2940&auto=format&fit=crop&ixlib=rb-4.0.3&ixid=M3wxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8fA%3D%3D)
  1. Go to a different chat
  2. Go back to the chat in Step 3
  3. Verify that LHN preview will show "text [Attachment]" format after returning to the same chat

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@nkdengineer
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@nkdengineer nkdengineer marked this pull request as ready for review April 8, 2024 10:47
@nkdengineer nkdengineer requested a review from a team as a code owner April 8, 2024 10:47
@melvin-bot melvin-bot bot requested review from danieldoglas and removed request for a team April 8, 2024 10:48
@danieldoglas
Copy link
Contributor

cc @shubham1206agra

@danieldoglas danieldoglas removed their request for review April 8, 2024 10:53
@nkdengineer
Copy link
Contributor Author

nkdengineer commented Apr 8, 2024 •
edited
Loading

@shubham1206agra I cannot send a message with image markdown like I could in the past, so now I cannot record screens.
Here is the message:

An inline image and some text ![off](https://images.unsplash.com/photo-1709983723739-d72ea88434dd?q=80&w=2940&auto=format&fit=crop&ixlib=rb-4.0.3&ixid=M3wxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8fA%3D%3D)

@marcochavezf
Copy link
Contributor

Hi @shubham1206agra, could you review when you have a chance?

@shubham1206agra
Copy link

@nkdengineer Can you fix test here?

@nkdengineer
Copy link
Contributor Author

@shubham1206agra I fixed

@shubham1206agra
Copy link

@marcochavezf You can merge this.

@nkdengineer nkdengineer mentioned this pull request Apr 12, 2024
Closed
6 tasks
@marcochavezf marcochavezf merged commit 0b1275e into Expensify:main Apr 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham1206agra shubham1206agra shubham1206agra approved these changes

@marcochavezf marcochavezf marcochavezf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nkdengineer @danieldoglas @marcochavezf @shubham1206agra