Create explicit rawInputReplacement
function for userMentions
#687
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the implementation of
userMentions
to include explicitrawInputReplacement
function. With this change we ensure that input string is not changed whenshouldKeepRawInput
flag is raisedFixed Issues
$ Expensify/App#40414
Tests
What unit/integration tests cover your change? What autoQA tests cover your change?
I"ve added unit test to catch the situation when input string contains phone number mention and
shouldKeepRawInput
flag is raised.What tests did you perform that validates your changed worked?
I've tested it inside
react-native-live-markdown
example library - with this change we no longer experience console.error described in linked issue.QA
Updating
expensify-common
version inside parser directory ofreact-native-live-markdown
and testing it inside it's example applicationAs we are only introducing separate
rawInputReplacement
there should be no regressions outside ofreact-native-live-markdown
and Composer component insideE/App