Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create explicit rawInputReplacement function for userMentions #687

Conversation

robertKozik
Copy link
Contributor

@robertKozik robertKozik commented Apr 22, 2024

Extends the implementation of userMentions to include explicit rawInputReplacement function. With this change we ensure that input string is not changed when shouldKeepRawInput flag is raised

Fixed Issues

$ Expensify/App#40414

Tests

  1. What unit/integration tests cover your change? What autoQA tests cover your change?
    I"ve added unit test to catch the situation when input string contains phone number mention and shouldKeepRawInput flag is raised.

  2. What tests did you perform that validates your changed worked?
    I've tested it inside react-native-live-markdown example library - with this change we no longer experience console.error described in linked issue.

QA

  1. What does QA need to do to validate your changes?
    Updating expensify-common version inside parser directory of react-native-live-markdown and testing it inside it's example application
  2. What areas to they need to test for regressions?
    As we are only introducing separate rawInputReplacement there should be no regressions outside of react-native-live-markdown and Composer component inside E/App

@robertKozik robertKozik requested a review from a team as a code owner April 22, 2024 16:32
@melvin-bot melvin-bot bot requested review from grgia and removed request for a team April 22, 2024 16:33
@pecanoro
Copy link
Contributor

@grgia All yours

@pecanoro
Copy link
Contributor

@grgia Friendly bump!

@pecanoro
Copy link
Contributor

I am merging the PR since it's been 2 days so we can bump the version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants