-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove data-code-raw for pre
blocks
#705
Remove data-code-raw for pre
blocks
#705
Conversation
pre
blocks
cc @dangrous since he was responsible for reviewing the previous PR and has context on what's happening here 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🚀Published to npm in v2.0.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much cleaner! Do we have a test in there that checks that urls inside
s work properly? Other than that I think this is good to go.
After we changed the syntax for codeFence we found a bug where it was possible to add a room mention inside of it. This PR prevents that from happening & removes
data-code-raw
which is not necessary after all of our changes.Fixed Issues
$ GH_LINK
Tests
All of the tests that were edited
I checked if there were any new errors inside of
react-native-live-markdown
library and inside of E/App (which was not necessary since these changes don't affect it).QA
Don't know actually, this is a clean-up rather than a feature
I've added some regression test to check for room mentions inside of codeFence