Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Log.alert usages #711

Closed
wants to merge 2 commits into from
Closed

Remove Log.alert usages #711

wants to merge 2 commits into from

Conversation

war-in
Copy link
Contributor

@war-in war-in commented Jun 3, 2024

Fixed Issues

$ Expensify/App#42161

Quick-fix PR removing Log.alert usages since it makes mobile apps fail. jQuery can't be used on mobile devices

Tests

  1. What unit/integration tests cover your change? What autoQA tests cover your change?
  2. What tests did you perform that validates your changed worked?

QA

  1. What does QA need to do to validate your changes?
  2. What areas to they need to test for regressions?

@war-in war-in marked this pull request as ready for review June 3, 2024 15:54
@war-in war-in requested a review from a team as a code owner June 3, 2024 15:54
@melvin-bot melvin-bot bot requested review from stitesExpensify and removed request for a team June 3, 2024 15:55
@blazejkustra blazejkustra mentioned this pull request Jun 3, 2024
Closed
@war-in
Copy link
Contributor Author

war-in commented Jun 4, 2024

Closing in favour of #712

@war-in war-in closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blazejkustra blazejkustra blazejkustra approved these changes

@stitesExpensify stitesExpensify Awaiting requested review from stitesExpensify

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@war-in @blazejkustra