Remove underscore from expensify-common and reduce usage of lodash and jQuery #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@puneetlath here is a new PR that have all commit signed |
|
@hungvu193 can you give it a once-over for good measure? |
Skalakid
changed the title
|
Sure |
hungvu193
reviewed
Jun 13, 2024
This was referenced Jun 13, 2024
|
All yours @puneetlath :D |
puneetlath
approved these changes
Jun 13, 2024
dangrous
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
LGTM!
Re: removing those rules, we should maybe call that out publicly, so that people know we should still try to follow them even if the linter says no. What do you think, @puneetlath?
|
@puneetlath @dangrous Who is brave enough to merge this one? 😄 |
|
🚀Published to npm in v2.0.15 |
|
@puneetlath @dangrous I've posted the announcement on #expensify-open-source |
|
Should we also upgrade expensify-common version in EApp? |
|
I think we should update in both LM and E/App @hungvu193. It's already merged in LM, here's the PR. |
|
Thanks for your information 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased version of #704 PR, that were made to sign all commits. Slack thread
The original goal of this PR was to remove
underscore,jQuery, andlodashfrom files that are connected toExpensiMarkso we can workletize these functions and enable thereact-native-live-markdownto run parser on UI thread. We wanted to block usage of these libraries in the whole repo, however without knowing the use cases and without being able to test it inside the private Expensify reposthat uses some of these files, we decided to:underscorefrom repo, since it's quite easy to do without testingunderscorefucntions withlodashversions because it doesn;t make. sene to re-write themExpensiMark,Logger,Srcso we can workletize functions from these files and run them on UI thread inreact-native-live-markdownFixed Issues
Expensify/App#42494
Tests
QA