Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix underscore ahead of asterisk not get bolded #751

Merged
merged 4 commits into from
Jul 15, 2024

Conversation

jp928
Copy link
Contributor

@jp928 jp928 commented Jul 12, 2024

Fix if underscore ahead of * not result in a bold style

Fixed Issues

Expensify/App#44032

Tests

  1. What unit/integration tests cover your change?
    A unit test is added in this PR.
  2. What tests did you perform that validates your changed worked?
    Apply this change to expensify/App to test.

QA

  1. What does QA need to do to validate your changes?
    typing _any words should result in a bold
  2. What areas to they need to test for regressions?
    NA

I have read the CLA Document and I hereby sign the CLA

@jp928 jp928 requested a review from a team as a code owner July 12, 2024 10:02
Copy link

github-actions bot commented Jul 12, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@melvin-bot melvin-bot bot requested review from johnmlee101 and removed request for a team July 12, 2024 10:03
@jp928
Copy link
Contributor Author

jp928 commented Jul 12, 2024

I have read the CLA Document and I hereby sign the CLA.

@parasharrajat
Copy link
Member

Let's change the title to explain what has been dine in this PR.

Update the issue on OP to only have issue link in raw format. Do not use markdown style links.

@jp928 jp928 changed the title Issues/44032 Fix underscore ahead of asterisk not get bolded Jul 13, 2024
Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎀 👀 🎀 C+ reviewed

@parasharrajat
Copy link
Member

@johnmlee101 All yours.

@johnmlee101 johnmlee101 merged commit 7149928 into Expensify:main Jul 15, 2024
6 checks passed
Copy link

🚀Published to npm in v2.0.45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants