Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bold tag isn't rendered as markdown when it has a style #783

Conversation

bernhardoj
Copy link
Contributor

@bernhardoj bernhardoj commented Aug 18, 2024

Fixed Issues

$ Expensify/App#46891

Tests

  1. What unit/integration tests cover your change? What autoQA tests cover your change?
    Updated unit test to cover bold tag with style.
  2. What tests did you perform that validates your changed worked?
  • Open a chat app that supports Markdown (Example: Slack)
  • Send a message containing a bold markdown
  • Copy the text with markdown and open NewDot
  • Open any chat and paste the copied text into the compose box
  • Verify the bold markdown is pasted instead of a plain text (only on Web/Desktop/iOS mWeb)
Android: Native
android.mp4
Android: mWeb Chrome
android.mweb.mp4
iOS: Native
ios.mp4
iOS: mWeb Safari
ios.mweb.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
desktop.mp4

QA

  1. What does QA need to do to validate your changes?
  2. What areas to they need to test for regressions?
    Same as Tests

@bernhardoj bernhardoj requested a review from a team as a code owner August 18, 2024 10:11
@melvin-bot melvin-bot bot requested review from pecanoro and removed request for a team August 18, 2024 10:11
@bernhardoj
Copy link
Contributor Author

NOTE:

Pasting HTML is only for web platforms. On Android mWeb, the clipboard data doesn't include HTML.
https://github.com/Expensify/App/blob/62722e8bc636f1be2e2c9e8e980aac93b76804c9/src/hooks/useHtmlPaste/index.ts#L117-L135

@bernhardoj
Copy link
Contributor Author

Additional video to make sure we don't break #710

web.mp4

@aldo-expensify aldo-expensify merged commit a30864e into Expensify:main Aug 20, 2024
6 checks passed
Copy link

🚀Published to npm in v2.0.77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants