Fix inline code regex mismatch when there is an escaped backtick character inside the backtick #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acter Signed-off-by: Tsaqif <[email protected]>
|
Taking this from you @Gonals since it's from my issue - Expensify/App#46917 - you're welcome to review if you like, though! |
dangrous
approved these changes
Aug 20, 2024
|
@ikevin127 ready for a look! |
|
🟢 Tests well, all cc @dangrous |
6 tasks
|
🚀Published to npm in v2.0.78 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Issues
$ Expensify/App#46917
Tests
What unit/integration tests cover your change? What autoQA tests cover your change?
I have add unit tests for this issue.
What tests did you perform that validates your changed worked?
Update the related regex in the expensify-common in node module and send the test messages from composer of the App.
Verify the displayed message is displayed correctly.
QA
What does QA need to do to validate your changes?
Same as test above
What areas to they need to test for regressions?
Inline code and code fence related tests.