Skip to content

Commit

Permalink
fix PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
SzymczakJ committed Nov 21, 2024
1 parent 3c1cb95 commit 73d95e1
Show file tree
Hide file tree
Showing 8 changed files with 10 additions and 13 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-web.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
uses: actions/checkout@v4

- name: Install node_modules
run: npm ci --ignore-scripts
run: npm ci

- name: Build app
working-directory: WebExample
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,6 @@ jobs:
npm run lint -- --fix --quiet
if ! git diff --name-only --exit-code; then
# shellcheck disable=SC2016
echo 'Error: Prettier diff detected! Please run `npm run lint --fix` and commit the changes.'
echo 'Error: Prettier diff detected! Please run `npm run lint -- --fix` and commit the changes.'
exit 1
fi
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v18
v18
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ We want this community to be friendly and respectful to each other. Please follo

## Development workflow

This project is a monorepo managed using [NPM workspaces](https://docs.npmjs.com/cli/v10/using-npm/workspaces). It contains the following packages:
This project is a monorepo managed using [npm workspaces](https://docs.npmjs.com/cli/v10/using-npm/workspaces). It contains the following packages:

- The library package in the root directory.
- An example app in the `example/` directory.
Expand Down
1 change: 0 additions & 1 deletion WebExample/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,5 @@ module.exports = async function (env, argv) {
},
argv,
);
config.resolve.fallback = {crypto: false};
return config;
};
2 changes: 0 additions & 2 deletions android/src/main/new_arch/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ file(GLOB LIB_MODULE_SRCS CONFIGURE_DEPENDS *.cpp)
file(GLOB LIB_CUSTOM_SRCS CONFIGURE_DEPENDS ${LIB_CUSTOM_SOURCES_DIR}/*.cpp)
file(GLOB LIB_CODEGEN_SRCS CONFIGURE_DEPENDS ${LIB_ANDROID_GENERATED_COMPONENTS_DIR}/*.cpp)

set(RN_DIR ${LIB_ANDROID_DIR}/../node_modules/react-native)

add_library(
${LIB_TARGET_NAME}
SHARED
Expand Down
2 changes: 1 addition & 1 deletion example/android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ react {
// root = file("../../")
// The folder where the react-native NPM package is. Default is ../../node_modules/react-native
reactNativeDir = file("../../../node_modules/react-native")
codegenDir = file("../../../node_modules/@react-native/codegen")
// The folder where the react-native Codegen package is. Default is ../../node_modules/@react-native/codegen
codegenDir = file("../../../node_modules/@react-native/codegen")
// The cli.js file which is the React Native CLI entrypoint. Default is ../../node_modules/react-native/cli.js
// cliFile = file("../../node_modules/react-native/cli.js")

Expand Down
10 changes: 5 additions & 5 deletions src/MarkdownTextInput.web.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ const MarkdownTextInput = React.forwardRef<MarkdownTextInput, MarkdownTextInputP
);

const handleOnSelect = useCallback(
(e: React.SyntheticEvent<HTMLDivElement>) => {
(e) => {
updateSelection(e);

// If the input has just been focused, we need to scroll the cursor into view
Expand Down Expand Up @@ -576,7 +576,7 @@ const MarkdownTextInput = React.forwardRef<MarkdownTextInput, MarkdownTextInputP
}, []);

const handleCut = useCallback(
(e: React.ClipboardEvent<HTMLDivElement>) => {
(e) => {
if (!divRef.current || !contentSelection.current) {
return;
}
Expand All @@ -589,7 +589,7 @@ const MarkdownTextInput = React.forwardRef<MarkdownTextInput, MarkdownTextInputP
);

const handlePaste = useCallback(
(e: React.ClipboardEvent<HTMLDivElement>) => {
(e) => {
if (e.isDefaultPrevented() || !divRef.current || !contentSelection.current) {
return;
}
Expand All @@ -606,7 +606,7 @@ const MarkdownTextInput = React.forwardRef<MarkdownTextInput, MarkdownTextInputP
}, []);

const endComposition = useCallback(
(e: React.CompositionEvent<HTMLDivElement>) => {
(e) => {
compositionRef.current = false;
handleOnChangeText(e);
},
Expand Down Expand Up @@ -741,7 +741,7 @@ const MarkdownTextInput = React.forwardRef<MarkdownTextInput, MarkdownTextInputP
onCopy={handleCopy}
onCut={handleCut}
onPaste={handlePaste}
// @ts-expect-error: we use placeholder attr to style it in css even though its not handled internally
// we use placeholder prop to style it in CSS even though its not handled internally
placeholder={heightSafePlaceholder}
spellCheck={spellCheck}
dir={dir}
Expand Down

0 comments on commit 73d95e1

Please sign in to comment.