Fix onSelectionChange event called twice with diferent payload on i…

…OS for multiline
Expensify · Feb 15, 2024 · ef3a8ab · ef3a8ab
1 parent e12b081
commit ef3a8ab
Showing 1 changed file with 15 additions and 4 deletions.
diff --git a/ios/RCTBaseTextInputView+Markdown.m b/ios/RCTBaseTextInputView+Markdown.m
@@ -27,10 +27,21 @@ - (void)markdown_updateLocalData
 {
   RCTMarkdownUtils *markdownUtils = [self getMarkdownUtils];
   if (markdownUtils != nil) {
-    UITextRange *range = self.backedTextInputView.selectedTextRange;
-    NSAttributedString *attributedText = [markdownUtils parseMarkdown:self.backedTextInputView.attributedText];
-    [self.backedTextInputView setAttributedText:attributedText];
-    [self.backedTextInputView setSelectedTextRange:range notifyDelegate:YES];
+    id<RCTBackedTextInputViewProtocol> backedTextInputView = self.backedTextInputView;
+    NSAttributedString *oldAttributedText = backedTextInputView.attributedText;
+    NSAttributedString *newAttributedText = [markdownUtils parseMarkdown:oldAttributedText];
+    if (![newAttributedText isEqualToAttributedString:oldAttributedText]) {
+      UITextRange *range = backedTextInputView.selectedTextRange;
+
+      // update attributed text without calling textInputDidChangeSelection and emitting onSelectionChange event
+      id<RCTBackedTextInputDelegate> delegate = backedTextInputView.textInputDelegate;
+      backedTextInputView.textInputDelegate = nil;
+      [backedTextInputView setAttributedText:newAttributedText];
+      backedTextInputView.textInputDelegate = delegate;
+
+      // restore original selection
+      [backedTextInputView setSelectedTextRange:range notifyDelegate:YES];
+    }
   }
 
   // Call the original method