Add selectionStart and selectionEnd variables to markdown input ref #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skalakid
requested review from
tomekzaw and
robertKozik
and removed request for
tomekzaw
robertKozik
previously approved these changes
Feb 9, 2024
tomekzaw
reviewed
Feb 12, 2024
src/MarkdownTextInput.web.tsx
Outdated
Comment on lines
176
to
177
| (divRef.current as HTMLInputElement).selectionStart = selection.start; | ||
| (divRef.current as HTMLInputElement).selectionEnd = selection.end; |
There was a problem hiding this comment.
Let's assign divRef.current to a new variable
tomekzaw
requested changes
Feb 14, 2024
src/MarkdownTextInput.web.tsx
Outdated
| markdownHTMLInput.selectionStart = selection.start; | ||
| markdownHTMLInput.selectionEnd = selection.end; | ||
| contentSelection.current = selection; | ||
| return selection; |
There was a problem hiding this comment.
Suggested change
| return selection; |
src/MarkdownTextInput.web.tsx
Outdated
Comment on lines
360
to
363
| const handleKeyUp = useCallback(() => { | ||
| updateSelection(); | ||
| }, []); | ||
|
|
There was a problem hiding this comment.
Suggested change
| const handleKeyUp = useCallback(() => { | |
| updateSelection(); | |
| }, []); |
src/MarkdownTextInput.web.tsx
Outdated
Comment on lines
368
to
369
| const selection = updateSelection(); | ||
| if (onSelectionChange && selection) { |
There was a problem hiding this comment.
Suggested change
| const selection = updateSelection(); | |
| if (onSelectionChange && selection) { | |
| updateSelection(); | |
| if (onSelectionChange && contentSelection.current) { |
src/MarkdownTextInput.web.tsx
Outdated
| @@ -488,6 +499,7 @@ const MarkdownTextInput = React.forwardRef<TextInput, MarkdownTextInputProps>( | |||
| autoCapitalize={autoCapitalize} | |||
| className={className} | |||
| onKeyDown={handleKeyPress} | |||
| onKeyUp={handleKeyUp} | |||
There was a problem hiding this comment.
Suggested change
| onKeyUp={handleKeyUp} | |
| onKeyUp={updateSelection} |
tomekzaw
approved these changes
Feb 14, 2024
This was referenced Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR fixes how our markdown text input tracks text selection and adds
selectionStartandselectionEndvariables to input ref.Related Issues
#173
Manual Tests
Using reproduction code from the linked issue start changing the text selection. Verify in console if it returns correct values. Next, position your cursor at the beginning of the markdown text input and after clicking
arrow up, verify if focus is changed into RN text input that is aboveLinked PRs
Expensify/App#36173