-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix layout issues on iOS on the new architecture #199
Merged
j-piasecki
merged 42 commits into
Expensify:main
from
j-piasecki:@jpiasecki/new-arch-ios
Apr 10, 2024
Merged
Fix layout issues on iOS on the new architecture #199
j-piasecki
merged 42 commits into
Expensify:main
from
j-piasecki:@jpiasecki/new-arch-ios
Apr 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
tomekzaw
reviewed
Feb 26, 2024
Co-authored-by: Tomek Zawadzki <[email protected]>
Co-authored-by: Tomek Zawadzki <[email protected]>
Co-authored-by: Tomek Zawadzki <[email protected]>
Co-authored-by: Tomek Zawadzki <[email protected]>
Co-authored-by: Tomek Zawadzki <[email protected]>
Co-authored-by: Tomek Zawadzki <[email protected]>
Co-authored-by: Tomek Zawadzki <[email protected]>
Co-authored-by: Tomek Zawadzki <[email protected]>
tomekzaw
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yolo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixes layout issues on the new architecture on iOS.
In more detail:
One caveat: in general we only want to apply formatting when the stored attributed string is using
Mode::Value
, otherwise (when it's usingMode::OpaquePointer
) the formatting should already be applied. There is one exception - before the text input is mounted, markdown tooling around it is not initialized, so even if the attributed string is usingMode::OpaquePointer
in this case, we should apply formatting during the transaction. This is done by forcing state updates for certain react tags since we don't have direct access to the shadow family from the decorator component.Before
Screen.Recording.2024-02-22.at.17.20.46.mov
After
Screen.Recording.2024-02-22.at.17.20.08.mov
Related Issues
Manual Tests
Linked PRs