Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing unit tests in webParser.test.tsx #206

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Fix failing unit tests in webParser.test.tsx #206

merged 1 commit into from
Feb 26, 2024

Conversation

tomekzaw
Copy link
Collaborator

@tomekzaw tomekzaw commented Feb 26, 2024 •
edited
Loading

Details

This PR fixes failing tests in webParser.test.tsx by doing two things:

  1. All <br> in expected strings were replaced with \n according to @Skalakid's recommendations
  2. One assertion was updated to match the output after merging Fix layout of nested blockquotes #202

Related Issues

GH_LINK

Manual Tests

Linked PRs

@tomekzaw tomekzaw requested a review from Skalakid February 26, 2024 13:26
Skalakid
Skalakid approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@Skalakid Skalakid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomekzaw tomekzaw merged commit 848543a into main Feb 26, 2024
2 checks passed
@tomekzaw tomekzaw deleted the @tomekzaw/fix-web-parser-tests branch February 26, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skalakid Skalakid Skalakid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomekzaw @Skalakid