Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff-based text replacing #209

Merged
merged 9 commits into from
Mar 7, 2024
Merged

Diff-based text replacing #209

merged 9 commits into from
Mar 7, 2024

Conversation

BartoszGrajdek
Copy link
Collaborator

@BartoszGrajdek BartoszGrajdek commented Mar 1, 2024

Details

This PR fixes a couple of problems mainly:
Text replacement issue on MacOS (chrome & safari, not supported on Firefox)
Spell-check on Chrome & safari (another PR will solve this issue on Firefox)

Related Issues

Expensify/App#36188
Expensify/App#36193

Manual Tests

For text replacement:

  1. Make sure that you have a text replacement available on your mac more info here - I have ,,cu" set up to be replaced with "see you"
  2. In your text input add some text like ,,hello world"
  3. Now try to add the text replacement i.e. I tried writing "current", in the bug mentioned it was replaced by "see yourrent", check if that's not happening anymore

For spellcheck:

  1. Try writing a word like "apple", while you're writing it shouldn't be underlined with a red curly line
  2. Now write an incorrect word like "appl" - depending on your browser spellcheck happens at different times, but overall it shouldn't happen while you're continuously writing a word

Linked PRs

Copy link

github-actions bot commented Mar 1, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@BartoszGrajdek
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

@BartoszGrajdek BartoszGrajdek requested a review from Skalakid March 4, 2024 09:59
Skalakid
Skalakid previously approved these changes Mar 5, 2024
@tomekzaw
Copy link
Collaborator

tomekzaw commented Mar 5, 2024

There seems to be a problem with the position of text replacement suggestion box in Chrome:

Screen.Recording.2024-03-05.at.12.27.22.mov

The suggestion box is not visible on Safari:

Screen.Recording.2024-03-05.at.12.35.06.mov

@tomekzaw
Copy link
Collaborator

tomekzaw commented Mar 5, 2024

I also found one regression on Safari, after adding newline the cursor disappears:

main this PR
before.mov
after.mov

@BartoszGrajdek BartoszGrajdek merged commit 3fba85d into main Mar 7, 2024
2 checks passed
@BartoszGrajdek BartoszGrajdek deleted the diff-parsing branch March 7, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants