-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diff-based text replacing #209
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
Skalakid
reviewed
Mar 4, 2024
tomekzaw
reviewed
Mar 4, 2024
Skalakid
previously approved these changes
Mar 5, 2024
There seems to be a problem with the position of text replacement suggestion box in Chrome: Screen.Recording.2024-03-05.at.12.27.22.movThe suggestion box is not visible on Safari: Screen.Recording.2024-03-05.at.12.35.06.mov |
I also found one regression on Safari, after adding newline the cursor disappears:
|
tomekzaw
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR fixes a couple of problems mainly:
Text replacement issue on MacOS (chrome & safari, not supported on Firefox)
Spell-check on Chrome & safari (another PR will solve this issue on Firefox)
Related Issues
Expensify/App#36188
Expensify/App#36193
Manual Tests
For text replacement:
For spellcheck:
Linked PRs