Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiline scroll fix #217

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Multiline scroll fix #217

merged 1 commit into from
Mar 8, 2024

Conversation

BartoszGrajdek
Copy link
Collaborator

Details

Related Issues

GH_LINK

Manual Tests

  1. Add numberOfLines to the component i.e. numberOfLines={5}
  2. Try adding more lines than the selected amount
  3. Make sure that the cursor is visible

Linked PRs

@BartoszGrajdek BartoszGrajdek requested review from tomekzaw and Skalakid and removed request for tomekzaw March 8, 2024 13:10
tomekzaw
tomekzaw approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Skalakid Skalakid merged commit 1171452 into main Mar 8, 2024
2 checks passed
@Skalakid Skalakid deleted the @BartoszGrajdek/height-fix branch March 8, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomekzaw tomekzaw tomekzaw approved these changes

@Skalakid Skalakid Skalakid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BartoszGrajdek @tomekzaw @Skalakid