Add onContentSizeChange prop #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
reviewed
Apr 12, 2024
src/MarkdownTextInput.web.tsx
Outdated
Comment on lines
314
to
315
| const newHeight = hostNode.offsetHeight; | ||
| const newWidth = hostNode.offsetWidth; |
There was a problem hiding this comment.
Just wondering if there's any reason for this order (height before width), is this intended?
There was a problem hiding this comment.
There is no reason behind this, is it like better to put width first? Does it make any difference?
There was a problem hiding this comment.
Nope, just wanted to ask.
BartoszGrajdek
previously approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR add
onContentSizeChangeprop to live markdown web implementation. This is a part of a jumping composer issue fixRelated Issues
GH_LINK
Manual Tests
onContentSizeChangeprop functionLinked PRs
Expensify/App#39267