Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump expensify-common - quotes are required to be followed by space #344

Merged
merged 3 commits into from
May 13, 2024

Conversation

robertKozik
Copy link
Collaborator

Details

Bumping expensify-common is connected with change in quotes behaviour - now it's required that quote sign is followed by at least one space

Related Issues

Expensify/App#41696

Manual Tests

Linked PRs

@tomekzaw
Copy link
Collaborator

Tests are failing :(

@robertKozik robertKozik requested a review from tomekzaw May 10, 2024 13:38
@robertKozik
Copy link
Collaborator Author

Forgot about web tests - fixed!

Copy link
Collaborator

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertKozik robertKozik merged commit 63ad7be into main May 13, 2024
4 checks passed
@robertKozik robertKozik deleted the expensify-common-quote-with-space branch May 13, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants