fix: use setBaseAndExtent instead of removeAllRanges #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dominictb <[email protected]>
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
@dominictb Thanks for the PR! We'll review it soon |
50 tasks
Skalakid
reviewed
May 27, 2024
Signed-off-by: dominictb <[email protected]>
|
@Skalakid could you help approve? Tks! |
Skalakid
approved these changes
May 28, 2024
This was referenced Jun 5, 2024
BartoszGrajdek
added a commit
that referenced
this pull request
Jun 10, 2024
This reverts commit 591af40.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Use
selection.setBaseAndExtentinstead ofselection.removeAllRanges(); selection.addRange(range)to avoid the keyboard on Android chrome to hideRelated Issues
$ Expensify/App#41137
PROPOSAL: Expensify/App#41137 (comment)
Manual Tests
Use Android chrome and go to the main page https://127.0.0.1:8082
Tap on a report
Paste any text repeatedly and note the page
Expected: The keyboard should remain open and visible after the paste. Also, the caret position must be maintained.
Linked PRs
Expensify/App#42622