Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TextInput ignore composition event on mWeb #366

Merged

Conversation

SzymczakJ
Copy link
Contributor

@SzymczakJ SzymczakJ commented Jun 4, 2024

Details

Related Issues

Expensify/App#42523

Manual Tests

Linked PRs

Copy link

github-actions bot commented Jun 4, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@SzymczakJ
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Collaborator

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's wait for @Skalakid and @BartoszGrajdek's approval.

Copy link
Collaborator

@Skalakid Skalakid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@BartoszGrajdek BartoszGrajdek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tomekzaw tomekzaw merged commit 4a2af73 into Expensify:main Jun 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants