Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move MarkdownType and MarkdownRange to commonTypes.ts #466

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

tomekzaw
Copy link
Collaborator

@tomekzaw tomekzaw commented Aug 31, 2024

Details

Follow-up to #464.

This PR removes duplicate declarations of MarkdownType and MarkdownRange types and moves them to commonTypes.ts.

I also fixed the incorrect type MarkdownMarkdownRange in global.d.ts that most likely happened during web refactor which now lets me remove some casts.

I skipped making changes to parser/index.ts since this file will be removed in #439.

Related Issues

GH_LINK

Manual Tests

Linked PRs

Copy link
Collaborator

@Skalakid Skalakid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@tomekzaw tomekzaw merged commit daddd81 into main Sep 2, 2024
5 checks passed
@tomekzaw tomekzaw deleted the @tomekzaw/add-common-types branch September 2, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants