-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update emoji font size if it was updated in markdownStyle
#475
Update emoji font size if it was updated in markdownStyle
#475
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
recheck |
Reviewing the PR |
@VickyStash Could you please merge main? |
@VickyStash Also, it looks like the change has been extracted from #356, was that intentional? Do you think we should merge your PR first and then follow with #356 or we should merge just #356? |
@VickyStash Thanks for your response. So it looks like your PR along with changes from #474 indeed fixes the emoji font size issue on RN 0.75. However, there's still a problem when updating text font size: Screen.Recording.2024-09-12.at.11.45.39.movIf you're okay with closing this PR in favor of #356 then let's do that. Thanks again for your investigation – Expensify/App#47547 (comment) is the best summary of what happened here. |
Closed in favor of #356 |
Actually we've found one regression in #356 (comment) so we can't merge #356 in its current form. Luckily, this regression doesn't happen on #475 (this PR): Screen.Recording.2024-09-12.at.12.00.16.movSo let's merge this PR as it fixes |
Details
This PR fixes iOS issue, when emoji fontSize updates in the markdownStyle has no right-away effect on the emoji display.
Related Issues
GH_LINK
Manual Tests
fixed_bug.mp4
Linked PRs
N/A