Merge pull request #469 from blazejkustra/ts/storage

[TS Migration] Migrate storage, utils and OnyxCache to Typescript

.eslintrc.js

@@ -53,6 +53,20 @@ module.exports = {
                 '@typescript-eslint/array-type': ['error', {default: 'array-simple'}],
                 '@typescript-eslint/consistent-type-definitions': 'off',
                 'rulesdir/no-multiple-onyx-in-file': 'off',
+                'valid-jsdoc': 'off',
+                'rulesdir/prefer-import-module-contents': 'off',
+                'es/no-optional-chaining': 'off',
+                'es/no-nullish-coalescing-operators': 'off',
+                'import/extensions': [
+                    'error',
+                    'ignorePackages',
+                    {
+                        js: 'never',
+                        jsx: 'never',
+                        ts: 'never',
+                        tsx: 'never',
+                    },
+                ],
             },
         },
         {

.gitignore

@@ -14,3 +14,6 @@ dist/
 
 # Decrypted private key we do not want to commit
 .github/OSBotify-private-key.asc
+
+# Published package
+*.tgz

lib/Onyx.js

@@ -542,7 +542,7 @@ function keysChanged(collectionKey, partialCollection, notifyRegularSubscibers =
                     const previousData = prevState[subscriber.statePropertyName];
 
                     // Avoids triggering unnecessary re-renders when feeding empty objects
-                    if (utils.areObjectsEmpty(data, previousData)) {
+                    if (utils.isEmptyObject(data) && utils.isEmptyObject(previousData)) {
                         return null;
                     }
                     if (data === previousData) {
@@ -674,7 +674,7 @@ function keyChanged(key, data, prevData, canUpdateSubscriber = () => true, notif
                 const prevWithOnyxData = prevState[subscriber.statePropertyName];
 
                 // Avoids triggering unnecessary re-renders when feeding empty objects
-                if (utils.areObjectsEmpty(data, prevWithOnyxData)) {
+                if (utils.isEmptyObject(data) && utils.isEmptyObject(prevWithOnyxData)) {
                     return null;
                 }
                 if (prevWithOnyxData === data) {