Merge pull request #480 from bernhardoj/fix/falsey-value-is-ignored

Re: Use initialValue when cached value is undefined
Expensify · Feb 28, 2024 · 950e257 · 950e257
2 parents 1e7844c + e44fd24
commit 950e257
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/withOnyx.js b/lib/withOnyx.js
@@ -59,7 +59,7 @@ export default function (mapOnyxToState, shouldDelayUpdates = false) {
                     (resultObj, mapping, propertyName) => {
                         const key = Str.result(mapping.key, props);
                         let value = Onyx.tryGetCachedValue(key, mapping);
-                        if (!value && mapping.initialValue) {
+                        if (value === undefined) {
                             value = mapping.initialValue;
                         }
 

diff --git a/tests/unit/withOnyxTest.js b/tests/unit/withOnyxTest.js
@@ -561,6 +561,10 @@ describe('withOnyxTest', () => {
                         key: ONYX_KEYS.SIMPLE_KEY,
                         initialValue: 'initialValue',
                     },
+                    simple2: {
+                        key: ONYX_KEYS.SIMPLE_KEY_2,
+                        initialValue: false,
+                    },
                 })(ViewWithCollections);
                 render(
                     <TestComponentWithOnyx
@@ -578,6 +582,7 @@ describe('withOnyxTest', () => {
                     onRender,
                     testObject: {isDefaultProp: true},
                     simple: 'initialValue',
+                    simple2: false,
                 });
             });
     });