Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Enforce Checklist with GitHub Action? #391

Open
marcaaron opened this issue Oct 5, 2023 · 0 comments
Open

Discussion: Enforce Checklist with GitHub Action? #391

marcaaron opened this issue Oct 5, 2023 · 0 comments
Labels
Planning Changes still in the thought process

Comments

@marcaaron
Copy link
Contributor

We use a very popular checklist in the Expensify/App repo that asks authors and reviewers to consider and perform some sane checks on testing, code quality, best practices, etc. In this repo, a combination of GitHub actions and webhooks remind and enforce that the checklist is filled out completely.

We added a similar checklist to react-native-onyx for consistency and to ensure some testing happens before merging. But there are no fancy GitHub actions to enforce that it happens.

Should we create one?

@marcaaron marcaaron added the Planning Changes still in the thought process label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Planning Changes still in the thought process
Projects
None yet
Development

No branches or pull requests

1 participant