Add The Checklist to react-native-onyx #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melvin-bot
bot
requested review from
arosiclair
and removed request for
a team
arosiclair
approved these changes
Oct 5, 2023
|
Not at the moment, but I can create one. I think @roryabraham has some plans to do "dynamic" checklists. So maybe whenever we figure that out we can try to mirror the changes to other repos. Might also not be totally "worth" doing if it's complex. I haven't had time to learn about the planned changes so would defer to @roryabraham on that one. |
|
We can continue discussing it here if there is time and interest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Coming from https://expensify.slack.com/archives/C01GTK53T8Q/p1696292810843059
Adding an amended version of the App checklist to
react-native-onyx. I tried to pull out some irrelevant things.We won't have the same enforcements that we have in App since we are not using the same GitHub actions, but this should be a decent reminder for now. The bar is currently very low for testing. And we had a couple of reverts.
Related Issues
❌
Automated Tests
❌
Linked PRs
❌