Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skippable Collection Member IDs #604

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Skippable Collection Member IDs #604

wants to merge 15 commits into from
+428 −26

Conversation

fabioh8010
Copy link
Contributor

@fabioh8010 fabioh8010 commented Dec 4, 2024 •
edited
Loading

Details

This PR introduces a new configuration to Onyx.init() – the option to specify skippable collection member IDs. It will be possible to pass an array of collection member IDs (strings) which updates will be ignored when using Onyx methods. Additionally, any subscribers from these keys to won't receive any data from Onyx.

Example:

// Onyx initialisation
Onyx.init({
    keys: ONYXKEYS,
    skippableCollectionMemberIDs: ['0', '-1', 'undefined', 'null', 'NaN'],
});

// Now, any updates to a collection member that has the specified IDs ('0', '-1', 'undefined', 'null', 'NaN')
// will be ignored and won't produce any effect in Onyx cache/storage.
// Onyx subscribes won't receive updates about these IDs.

// Let's assume it's undefined.
const reportID = undefined;

// Result key is `report_undefined`. This operation won't produce any changes because the collection member ID `undefined`
// was configured to be skipped.
Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`, {...});

// useOnyx will never receive a report, even if it was stored previously by mistake in a `report_undefined` key.
const [report] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`);

Related Issues

Expensify/App#50360

Automated Tests

Unit tests were created to cover the changes.

Manual Tests

General tests in E/App:

  1. Login with an account.
  2. Go to a chat and send a message. React to that message.
  3. Create a thread from that message and send a message inside.
  4. Create a task in the chat. Go to its details and mark it as complete.
  5. Go to FAB -> Create Expense. Send it to someone. Go to Reports tab and access the expense's details.
  6. Go to Settings and logout the user.

Author Checklist

  • I linked the correct issue in the ### Related Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
Screen.Recording.2025-01-16.at.17.44.45-compressed.mov
Android: mWeb Chrome
Screen.Recording.2025-01-16.at.17.49.30-compressed.mov
iOS: Native
Screen.Recording.2025-01-16.at.18.17.09-compressed.mov
iOS: mWeb Safari
Screen.Recording.2025-01-16.at.18.19.00-compressed.mov
MacOS: Chrome / Safari
Screen.Recording.2025-01-16.at.18.22.10-compressed.mov
Screen.Recording.2025-01-16.at.18.23.35-compressed.mov
MacOS: Desktop
Screen.Recording.2025-01-16.at.18.27.06-compressed.mov

@fabioh8010 fabioh8010 mentioned this pull request Dec 4, 2024
Open
VickyStash
VickyStash reviewed Dec 17, 2024
View reviewed changes
lib/Onyx.ts Outdated Show resolved Hide resolved
@fabioh8010
Copy link
Contributor Author

Updates:

  • Went back to this PR, proceeding with the profiling of the app.

@fabioh8010
Copy link
Contributor Author

I've just profiled the Onyx changes -- no significant changes in performance ✅

Profiling

main Onyx branch

Startup / Open Big Report

  • Render time (ms): 7373 / 7350 / 7380

Switch to Big Report

  • Render time (ms): 4392 / 4373 / 4470

Send Message

  • Render time (ms): 1340 / 1246 / 1247

Create Expense Flow

  • Render time (ms): 6025 / 6103 / 6550

skippable member IDs Onyx branch

Open Big Report

  • Render time (ms): 7350 / 7432 / 7368

Switch to Big Report

  • Render time (ms): 4359 / 4216 / 4343

Send Message

  • Render time (ms): 1379 / 1295 / 1401

Create Expense Flow

  • Render time (ms): 5902 / 5840 / 5910

Reassure

  • Current: feature/onyx-skippable-collection-member-ids (4b09608cb716f0c64219d00f3c735a69eceb1b31) - 2025-01-13 21:56:57Z
  • Baseline: feature/onyx-skippable-collection-member-ids (4b09608cb716f0c64219d00f3c735a69eceb1b31) - 2025-01-13 21:48:01Z

Significant Changes To Duration

Name Type Duration Count
OptionsListUtils [OptionsListUtils] getShareLogOptions function 37.6 ms → 33.1 ms (-4.5 ms, -11.9%) 🟢 1 → 1
OptionsListUtils [OptionsListUtils] getSearchOptions function 67.4 ms → 62.4 ms (-5.1 ms, -7.5%) 🟢 1 → 1
OptionsListUtils [OptionsListUtils] getShareDestinationOptions function 61.3 ms → 56.1 ms (-5.1 ms, -8.4%) 🟢 1 → 1
SidebarUtils [SidebarUtils] getOrderedReportIDs on 15k reports for default priorityMode function 209.3 ms → 201.5 ms (-7.8 ms, -3.7%) 1 → 1
Show details
Name Type Duration Count
OptionsListUtils [OptionsListUtils] getShareLogOptions function Baseline
Mean: 37.6 ms
Stdev: 2.1 ms (5.5%)
Runs: 36.9 41.9 37.5 36.2 39.6 35.9 39.0 36.1 35.2 37.6

Current
Mean: 33.1 ms
Stdev: 1.1 ms (3.4%)
Runs: 32.6 32.3 33.6 32.0 32.3 35.5 34.4 32.5 33.5 32.4		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
OptionsListUtils [OptionsListUtils] getSearchOptions function Baseline
Mean: 67.4 ms
Stdev: 2.3 ms (3.4%)
Runs: 65.0 69.4 64.7 68.4 65.1 68.8 66.7 69.3 65.6 71.3

Current
Mean: 62.4 ms
Stdev: 1.3 ms (2.1%)
Runs: 61.3 63.3 61.1 63.4 63.4 63.9 60.8 64.0 61.5 61.2		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
OptionsListUtils [OptionsListUtils] getShareDestinationOptions function Baseline
Mean: 61.3 ms
Stdev: 2.1 ms (3.5%)
Runs: 64.0 59.2 59.4 63.1 61.8 63.6 59.2 63.7 59.3 59.7

Current
Mean: 56.1 ms
Stdev: 1.9 ms (3.3%)
Runs: 54.7 57.3 54.4 57.3 54.7 55.3 59.9 56.4 57.4 53.9		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
SidebarUtils [SidebarUtils] getOrderedReportIDs on 15k reports for default priorityMode function Baseline
Mean: 209.3 ms
Stdev: 2.0 ms (0.9%)
Runs: 210.7 211.5 208.0 206.0 211.2 207.2 211.2 207.7 210.5 209.1

Current
Mean: 201.5 ms
Stdev: 1.8 ms (0.9%)
Runs: 201.3 199.9 203.8 200.2 205.1 200.8 201.7 202.4 199.2 200.9		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Meaningless Changes To Duration

Show entries
Name Type Duration Count
[BaseOptionsList] Should press a list item render 0.0 ms → 0.0 ms 4 → 4
[BaseOptionsList] Should render 1 section and a thousand items render 0.0 ms → 0.0 ms 1 → 1
[BaseOptionsList] Should render multiple selection and select 4 items render 0.0 ms → 0.0 ms 13 → 13
[BaseOptionsList] Should scroll and select a few items render 0.0 ms → 0.0 ms 14 → 14
[GooglePlacesUtils] getAddressComponents on a big dataset function 0.0 ms → 0.0 ms (+0.0 ms, +3.9%) 1 → 1
[ModifiedExpenseMessage] getForReportAction on 1k reports and policies function 0.1 ms → 0.1 ms (+0.0 ms, +3.2%) 1 → 1
[ReportActionCompose] should press create button render 0.0 ms → 0.0 ms 13 → 13
[ReportActionCompose] should press send message button render 0.0 ms → 0.0 ms 12 → 12
[ReportActionCompose] should render Composer with text input interactions render 0.0 ms → 0.0 ms 13 → 13
[ReportActionsList] should render ReportActionsList with 500 reportActions stored render 0.0 ms → 0.0 ms 7 → 7
[SearchRouter] should react to text input changes render 0.0 ms → 0.0 ms 11 → 11
[SearchRouter] should render list with cached options render 0.0 ms → 0.0 ms 9 → 9
[SelectionList] should press a list item render 0.0 ms → 0.0 ms 4 → 4
[SelectionList] should render 1 section and a thousand items render 0.0 ms → 0.0 ms 1 → 1
[SelectionList] should render multiple selection and select 3 items render 0.0 ms → 0.0 ms 8 → 8
[SelectionList] should scroll and select a few items render 0.0 ms → 0.0 ms 12 → 12
OptionsListUtils [OptionsListUtils] empty search term with selected options and mocked personal details function 3.5 ms → 3.3 ms (-0.3 ms, -7.2%) 1 → 1
OptionsListUtils [OptionsListUtils] getFilteredOptions with search value function 24.6 ms → 22.0 ms (-2.7 ms, -10.9%) 1 → 1
OptionsListUtils [OptionsListUtils] getMemberInviteOptions function 2.0 ms → 2.3 ms (+0.3 ms, +14.6%) 1 → 1
OptionsListUtils [OptionsListUtils] worst case scenario with a search term that matches a subset of selectedOptions, filteredRecentReports, and filteredPersonalDetails function 15.9 ms → 15.7 ms (-0.2 ms, -1.0%) 1 → 1
PolicyUtils getMemberAccountIDsForWorkspace 500 policy members with errors and personal details function 0.1 ms → 0.1 ms (+0.0 ms, +3.8%) 1 → 1
PolicyUtils getMemberAccountIDsForWorkspace 500 policy members with personal details function 0.1 ms → 0.1 ms (-0.0 ms, -8.2%) 1 → 1
ReportActionsUtils [ReportActionsUtils] getLastClosedReportAction on 10k ReportActions function 0.6 ms → 0.6 ms (-0.0 ms, -1.8%) 1 → 1
ReportActionsUtils [ReportActionsUtils] getLastVisibleAction on 10k reportActions function 12.0 ms → 12.5 ms (+0.5 ms, +3.8%) 1 → 1
ReportActionsUtils [ReportActionsUtils] getLastVisibleAction on 10k reportActions with actionsToMerge function 12.8 ms → 12.7 ms (-0.0 ms, ±0.0%) 1 → 1
ReportActionsUtils [ReportActionsUtils] getLastVisibleMessage on 10k ReportActions function 12.5 ms → 12.8 ms (+0.3 ms, +2.8%) 1 → 1
ReportActionsUtils [ReportActionsUtils] getLastVisibleMessage on 10k ReportActions with actionsToMerge function 12.8 ms → 13.2 ms (+0.4 ms, +3.1%) 1 → 1
ReportActionsUtils [ReportActionsUtils] getMostRecentIOURequestActionID on 10k ReportActions function 0.0 ms → 0.0 ms (+0.0 ms, +43.5%) 🔴 1 → 1
ReportActionsUtils [ReportActionsUtils] getMostRecentReportActionLastModified function 2.0 ms → 2.2 ms (+0.2 ms, +9.9%) 1 → 1
ReportActionsUtils [ReportActionsUtils] getSortedReportActionsForDisplay on 10k ReportActions function 0.6 ms → 0.6 ms (+0.0 ms, +6.6%) 1 → 1
ReportUtils [ReportUtils] canDeleteReportAction on 1k reports and policies function 0.0 ms → 0.0 ms (-0.0 ms, -29.9%) 🟢 1 → 1
ReportUtils [ReportUtils] canShowReportRecipientLocalTime on 1k participants function 0.0 ms → 0.0 ms (+0.0 ms, +14.3%) 1 → 1
ReportUtils [ReportUtils] findLastAccessedReport on 2k reports and policies function 0.2 ms → 0.3 ms (+0.0 ms, +13.9%) 1 → 1
ReportUtils [ReportUtils] getDisplayNamesWithTooltips 1k participants function 1.1 ms → 1.5 ms (+0.4 ms, +38.0%) 🔴 1 → 1
ReportUtils [ReportUtils] getIcons on 1k participants function 0.0 ms → 0.1 ms (+0.0 ms, +348.9%) 🔴 1 → 1
ReportUtils [ReportUtils] getIconsForParticipants on 1k participants function 0.9 ms → 0.9 ms (+0.0 ms, +1.1%) 1 → 1
ReportUtils [ReportUtils] getIOUReportActionDisplayMessage on 1k policies function 0.0 ms → 0.0 ms (-0.0 ms, -5.7%) 1 → 1
ReportUtils [ReportUtils] getMoneyRequestOptions on 1k participants function 0.0 ms → 0.0 ms (-0.0 ms, -8.1%) 1 → 1
ReportUtils [ReportUtils] getReportName on 1k participants function 0.0 ms → 0.0 ms (+0.0 ms, +126.6%) 🔴 1 → 1
ReportUtils [ReportUtils] getReportPreviewMessage on 1k policies function 0.1 ms → 0.1 ms (-0.0 ms, -2.6%) 1 → 1
ReportUtils [ReportUtils] getReportRecipientAccountID on 1k participants function 0.0 ms → 0.0 ms (+0.0 ms, +927.9%) 🔴 1 → 1
ReportUtils [ReportUtils] getTransactionDetails on 1k reports function 0.1 ms → 0.1 ms (+0.0 ms, +4.4%) 1 → 1
ReportUtils [ReportUtils] getWorkspaceChat on 1k policies function 0.1 ms → 0.2 ms (+0.0 ms, +2.4%) 1 → 1
ReportUtils [ReportUtils] getWorkspaceIcon on 1k policies function 0.0 ms → 0.0 ms (-0.0 ms, -25.4%) 🟢 1 → 1
ReportUtils [ReportUtils] shouldReportBeInOptionList on 1k participant function 0.0 ms → 0.0 ms (+0.0 ms, +364.8%) 🔴 1 → 1
SidebarLinks [SidebarLinks] should click on list item render 0.0 ms → 0.0 ms 9 → 9
SidebarLinks [SidebarLinks] should render Sidebar with 500 reports stored render 0.0 ms → 0.0 ms 8 → 8
SidebarUtils [SidebarUtils] getOptionData function 1.6 ms → 1.5 ms (-0.1 ms, -5.1%) 1 → 1
SidebarUtils [SidebarUtils] getOrderedReportIDs on 15k reports for GSD priorityMode function 195.5 ms → 192.2 ms (-3.3 ms, -1.7%) 1 → 1
Show details
Name Type Duration Count
[BaseOptionsList] Should press a list item render Baseline
Mean: 0.0 ms
Stdev: 0.0 ms (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0

Current
Mean: 0.0 ms
Stdev: 0.0 ms (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0		 Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
[BaseOptionsList] Should render 1 section and a thousand items render Baseline
Mean: 0.0 ms
Stdev: 0.0 ms (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0

Current
Mean: 0.0 ms
Stdev: 0.0 ms (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
[BaseOptionsList] Should render multiple selection and select 4 items render Baseline
Mean: 0.0 ms
Stdev: 0.0 ms (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0

Current
Mean: 0.0 ms
Stdev: 0.0 ms (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0		 Baseline
Mean: 13
Stdev: 0 (0.0%)
Runs: 13 13 13 13 13 13 13 13 13 13

Current
Mean: 13
Stdev: 0 (0.0%)
Runs: 13 13 13 13 13 13 13 13 13 13
[BaseOptionsList] Should scroll and select a few items render Baseline
Mean: 0.0 ms
Stdev: 0.0 ms (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0

Current
Mean: 0.0 ms
Stdev: 0.0 ms (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0		 Baseline
Mean: 14
Stdev: 0 (0.0%)
Runs: 14 14 14 14 14 14 14 14 14 14

Current
Mean: 14
Stdev: 0 (0.0%)
Runs: 14 14 14 14 14 14 14 14 14 14
[GooglePlacesUtils] getAddressComponents on a big dataset function Baseline
Mean: 0.0 ms
Stdev: 0.0 ms (24.3%)
Runs: 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0

Current
Mean: 0.0 ms
Stdev: 0.0 ms (23.5%)
Runs: 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
[ModifiedExpenseMessage] getForReportAction on 1k reports and policies function Baseline
Mean: 0.1 ms
Stdev: 0.0 ms (65.8%)
Runs: 0.2 0.1 0.0 0.0 0.0 0.0 0.0 0.1 0.0 0.0

Current
Mean: 0.1 ms
Stdev: 0.0 ms (70.5%)
Runs: 0.2 0.1 0.0 0.0 0.0 0.0 0.0 0.1 0.0 0.0		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
[ReportActionCompose] should press create button render Baseline
Mean: 0.0 ms
Stdev: 0.0 ms (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0

Current
Mean: 0.0 ms
Stdev: 0.0 ms (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0		 Baseline
Mean: 13
Stdev: 0 (0.0%)
Runs: 13 13 13 13 13 13 13 13 13 13

Current
Mean: 13
Stdev: 0 (0.0%)
Runs: 13 13 13 13 13 13 13 13 13 13
[ReportActionCompose] should press send message button render Baseline
Mean: 0.0 ms
Stdev: 0.0 ms (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0

Current
Mean: 0.0 ms
Stdev: 0.0 ms (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0		 Baseline
Mean: 12
Stdev: 0 (0.0%)
Runs: 12 12 12 12 12 12 12 12 12 12

Current
Mean: 12
Stdev: 0 (0.0%)
Runs: 12 12 12 12 12 12 12 12 12 12
[ReportActionCompose] should render Composer with text input interactions render Baseline
Mean: 0.0 ms
Stdev: 0.0 ms (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0

Current
Mean: 0.0 ms
Stdev: 0.0 ms (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0		 Baseline
Mean: 13
Stdev: 0 (0.0%)
Runs: 13 13 13 13 13 13 13 13 13 13

Current
Mean: 13
Stdev: 0 (0.0%)
Runs: 13 13 13 13 13 13 13 13 13 13
[ReportActionsList] should render ReportActionsList with 500 reportActions stored render Baseline
Mean: 0.0 ms
Stdev: 0.0 ms (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0

Current
Mean: 0.0 ms
Stdev: 0.0 ms (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0		 Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7

Current
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
[SearchRouter] should react to text input changes render Baseline
Mean: 0.0 ms
Stdev: 0.0 ms (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0

Current
Mean: 0.0 ms
Stdev: 0.0 ms (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0		 Baseline
Mean: 11
Stdev: 0 (0.0%)
Runs: 11 11 11 11 11 11 11 11 11 11

Current
Mean: 11
Stdev: 0 (0.0%)
Runs: 11 11 11 11 11 11 11 11 11 11
[SearchRouter] should render list with cached options render Baseline
Mean: 0.0 ms
Stdev: 0.0 ms (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0

Current
Mean: 0.0 ms
Stdev: 0.0 ms (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0		 Baseline
Mean: 9
Stdev: 0 (0.0%)
Runs: 9 9 9 9 9 9 9 9 9 9

Current
Mean: 9
Stdev: 0 (0.0%)
Runs: 9 9 9 9 9 9 9 9 9 9
[SelectionList] should press a list item render Baseline
Mean: 0.0 ms
Stdev: 0.0 ms (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0

Current
Mean: 0.0 ms
Stdev: 0.0 ms (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0		 Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
[SelectionList] should render 1 section and a thousand items render Baseline
Mean: 0.0 ms
Stdev: 0.0 ms (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0

Current
Mean: 0.0 ms
Stdev: 0.0 ms (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
[SelectionList] should render multiple selection and select 3 items render Baseline
Mean: 0.0 ms
Stdev: 0.0 ms (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0

Current
Mean: 0.0 ms
Stdev: 0.0 ms (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0		 Baseline
Mean: 8
Stdev: 0 (0.0%)
Runs: 8 8 8 8 8 8 8 8 8 8

Current
Mean: 8
Stdev: 0 (0.0%)
Runs: 8 8 8 8 8 8 8 8 8 8
[SelectionList] should scroll and select a few items render Baseline
Mean: 0.0 ms
Stdev: 0.0 ms (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0

Current
Mean: 0.0 ms
Stdev: 0.0 ms (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0		 Baseline
Mean: 12
Stdev: 0 (0.0%)
Runs: 12 12 12 12 12 12 12 12 12 12

Current
Mean: 12
Stdev: 0 (0.0%)
Runs: 12 12 12 12 12 12 12 12 12 12
OptionsListUtils [OptionsListUtils] empty search term with selected options and mocked personal details function Baseline
Mean: 3.5 ms
Stdev: 1.3 ms (37.7%)
Runs: 2.9 2.9 2.9 5.8 2.8 2.8 2.8 3.7 2.8 6.3

Current
Mean: 3.3 ms
Stdev: 0.8 ms (25.3%)
Runs: 4.9 2.9 2.9 2.8 2.8 2.7 4.8 2.9 2.8 3.3		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
OptionsListUtils [OptionsListUtils] getFilteredOptions with search value function Baseline
Mean: 24.6 ms
Stdev: 1.0 ms (3.9%)
Runs: 25.8 24.7 24.3 22.4 25.8 25.4 24.4 24.7 24.6 24.5

Current
Mean: 22.0 ms
Stdev: 0.6 ms (2.5%)
Runs: 22.8 22.4 22.1 22.1 20.7 21.9 21.7 21.7 22.1 22.0		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
OptionsListUtils [OptionsListUtils] getMemberInviteOptions function Baseline
Mean: 2.0 ms
Stdev: 0.0 ms (1.7%)
Runs: 2.0 1.9 2.0 2.0 2.0 2.0 2.0 2.0 2.0 2.1

Current
Mean: 2.3 ms
Stdev: 0.9 ms (37.9%)
Runs: 2.0 2.0 2.0 2.0 2.0 2.0 2.0 2.0 4.7 2.2		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
OptionsListUtils [OptionsListUtils] worst case scenario with a search term that matches a subset of selectedOptions, filteredRecentReports, and filteredPersonalDetails function Baseline
Mean: 15.9 ms
Stdev: 1.4 ms (8.6%)
Runs: 16.4 19.6 15.5 15.4 15.3 15.3 15.3 15.3 15.3 15.2

Current
Mean: 15.7 ms
Stdev: 0.1 ms (0.6%)
Runs: 15.9 15.8 15.7 15.7 15.8 15.7 15.7 15.7 15.6 15.6		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
PolicyUtils getMemberAccountIDsForWorkspace 500 policy members with errors and personal details function Baseline
Mean: 0.1 ms
Stdev: 0.0 ms (1.3%)
Runs: 0.1 0.1 0.1 0.1 0.1 0.1 0.1 0.1 0.1 0.1

Current
Mean: 0.1 ms
Stdev: 0.0 ms (2.2%)
Runs: 0.1 0.1 0.1 0.1 0.1 0.1 0.1 0.1 0.1 0.1		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
PolicyUtils getMemberAccountIDsForWorkspace 500 policy members with personal details function Baseline
Mean: 0.1 ms
Stdev: 0.0 ms (17.3%)
Runs: 0.1 0.1 0.1 0.1 0.1 0.1 0.1 0.1 0.1 0.1

Current
Mean: 0.1 ms
Stdev: 0.0 ms (22.7%)
Runs: 0.1 0.1 0.1 0.1 0.1 0.1 0.1 0.1 0.1 0.1		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
ReportActionsUtils [ReportActionsUtils] getLastClosedReportAction on 10k ReportActions function Baseline
Mean: 0.6 ms
Stdev: 0.0 ms (3.3%)
Runs: 0.6 0.6 0.6 0.6 0.6 0.6 0.6 0.6 0.6 0.6

Current
Mean: 0.6 ms
Stdev: 0.0 ms (3.9%)
Runs: 0.6 0.6 0.6 0.6 0.6 0.6 0.6 0.6 0.6 0.6		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
ReportActionsUtils [ReportActionsUtils] getLastVisibleAction on 10k reportActions function Baseline
Mean: 12.0 ms
Stdev: 1.0 ms (8.5%)
Runs: 11.8 11.7 11.6 11.6 11.7 11.7 14.9 11.8 11.7 11.6

Current
Mean: 12.5 ms
Stdev: 1.5 ms (12.3%)
Runs: 15.7 12.1 11.7 11.6 11.6 11.6 11.5 12.1 15.0 12.0		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
ReportActionsUtils [ReportActionsUtils] getLastVisibleAction on 10k reportActions with actionsToMerge function Baseline
Mean: 12.8 ms
Stdev: 0.8 ms (6.3%)
Runs: 12.5 12.5 12.5 15.0 12.5 12.5 12.5 12.6 12.6 12.4

Current
Mean: 12.7 ms
Stdev: 0.7 ms (5.6%)
Runs: 12.6 12.6 12.6 12.5 12.4 14.7 12.6 12.4 12.4 12.5		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
ReportActionsUtils [ReportActionsUtils] getLastVisibleMessage on 10k ReportActions function Baseline
Mean: 12.5 ms
Stdev: 0.8 ms (6.7%)
Runs: 12.8 12.1 12.0 12.2 12.2 12.2 12.0 14.7 12.3 12.1

Current
Mean: 12.8 ms
Stdev: 0.8 ms (6.6%)
Runs: 13.0 14.3 12.2 12.0 12.5 12.5 12.2 12.4 12.5 14.3		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
ReportActionsUtils [ReportActionsUtils] getLastVisibleMessage on 10k ReportActions with actionsToMerge function Baseline
Mean: 12.8 ms
Stdev: 0.7 ms (5.5%)
Runs: 12.5 12.8 12.6 14.8 12.6 12.5 12.6 12.4 12.4 12.5

Current
Mean: 13.2 ms
Stdev: 0.9 ms (6.9%)
Runs: 12.8 12.7 12.8 12.8 12.6 12.6 15.6 13.7 13.2 13.0		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
ReportActionsUtils [ReportActionsUtils] getMostRecentIOURequestActionID on 10k ReportActions function Baseline
Mean: 0.0 ms
Stdev: 0.0 ms (210.9%)
Runs: 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.1

Current
Mean: 0.0 ms
Stdev: 0.0 ms (209.8%)
Runs: 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.1		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
ReportActionsUtils [ReportActionsUtils] getMostRecentReportActionLastModified function Baseline
Mean: 2.0 ms
Stdev: 0.1 ms (5.1%)
Runs: 2.2 2.0 1.9 1.8 2.0 2.0 1.9 2.0 1.9 1.9

Current
Mean: 2.2 ms
Stdev: 0.7 ms (32.7%)
Runs: 1.9 2.0 4.2 2.0 1.9 2.0 1.9 1.8 1.9 1.9		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
ReportActionsUtils [ReportActionsUtils] getSortedReportActionsForDisplay on 10k ReportActions function Baseline
Mean: 0.6 ms
Stdev: 0.0 ms (2.9%)
Runs: 0.6 0.6 0.6 0.6 0.6 0.6 0.6 0.6 0.6 0.6

Current
Mean: 0.6 ms
Stdev: 0.0 ms (3.0%)
Runs: 0.7 0.7 0.6 0.6 0.6 0.6 0.6 0.6 0.6 0.6		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
ReportUtils [ReportUtils] canDeleteReportAction on 1k reports and policies function Baseline
Mean: 0.0 ms
Stdev: 0.0 ms (62.6%)
Runs: 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0

Current
Mean: 0.0 ms
Stdev: 0.0 ms (90.0%)
Runs: 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
ReportUtils [ReportUtils] canShowReportRecipientLocalTime on 1k participants function Baseline
Mean: 0.0 ms
Stdev: 0.0 ms (89.0%)
Runs: 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0

Current
Mean: 0.0 ms
Stdev: 0.0 ms (50.7%)
Runs: 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
ReportUtils [ReportUtils] findLastAccessedReport on 2k reports and policies function Baseline
Mean: 0.2 ms
Stdev: 0.0 ms (5.8%)
Runs: 0.3 0.2 0.2 0.3 0.2 0.2 0.2 0.2 0.3 0.2

Current
Mean: 0.3 ms
Stdev: 0.1 ms (21.2%)
Runs: 0.4 0.3 0.3 0.3 0.3 0.3 0.2 0.2 0.3 0.3		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
ReportUtils [ReportUtils] getDisplayNamesWithTooltips 1k participants function Baseline
Mean: 1.1 ms
Stdev: 0.1 ms (4.7%)
Runs: 1.2 1.2 1.1 1.1 1.1 1.1 1.1 1.1 1.1 1.1

Current
Mean: 1.5 ms
Stdev: 0.1 ms (7.7%)
Runs: 1.7 1.5 1.6 1.5 1.4 1.3 1.6 1.5 1.4 1.5		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
ReportUtils [ReportUtils] getIcons on 1k participants function Baseline
Mean: 0.0 ms
Stdev: 0.0 ms (164.7%)
Runs: 0.1 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0

Current
Mean: 0.1 ms
Stdev: 0.1 ms (93.0%)
Runs: 0.2 0.0 0.0 0.0 0.0 0.0 0.0 0.1 0.0 0.0		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
ReportUtils [ReportUtils] getIconsForParticipants on 1k participants function Baseline
Mean: 0.9 ms
Stdev: 0.1 ms (9.4%)
Runs: 1.1 0.9 0.8 0.8 0.8 0.9 0.9 0.9 0.9 0.8

Current
Mean: 0.9 ms
Stdev: 0.1 ms (10.1%)
Runs: 1.1 0.9 0.9 0.8 0.9 0.9 0.9 0.9 0.9 0.9		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
ReportUtils [ReportUtils] getIOUReportActionDisplayMessage on 1k policies function Baseline
Mean: 0.0 ms
Stdev: 0.0 ms (109.1%)
Runs: 0.0 0.1 0.0 0.0 0.1 0.0 0.0 0.0 0.0 0.0

Current
Mean: 0.0 ms
Stdev: 0.0 ms (112.6%)
Runs: 0.0 0.1 0.0 0.0 0.1 0.0 0.0 0.0 0.0 0.0		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
ReportUtils [ReportUtils] getMoneyRequestOptions on 1k participants function Baseline
Mean: 0.0 ms
Stdev: 0.0 ms (78.1%)
Runs: 0.0 0.0 0.0 0.1 0.0 0.0 0.0 0.0 0.0 0.1

Current
Mean: 0.0 ms
Stdev: 0.0 ms (62.7%)
Runs: 0.0 0.0 0.0 0.1 0.0 0.0 0.0 0.0 0.0 0.1		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
ReportUtils [ReportUtils] getReportName on 1k participants function Baseline
Mean: 0.0 ms
Stdev: 0.0 ms (31.5%)
Runs: 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0

Current
Mean: 0.0 ms
Stdev: 0.0 ms (172.2%)
Runs: 0.0 0.1 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
ReportUtils [ReportUtils] getReportPreviewMessage on 1k policies function Baseline
Mean: 0.1 ms
Stdev: 0.0 ms (46.6%)
Runs: 0.1 0.1 0.1 0.2 0.1 0.1 0.1 0.1 0.1 0.0

Current
Mean: 0.1 ms
Stdev: 0.1 ms (60.0%)
Runs: 0.1 0.1 0.1 0.2 0.1 0.1 0.0 0.0 0.1 0.0		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
ReportUtils [ReportUtils] getReportRecipientAccountID on 1k participants function Baseline
Mean: 0.0 ms
Stdev: 0.0 ms (61.6%)
Runs: 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0

Current
Mean: 0.0 ms
Stdev: 0.0 ms (285.0%)
Runs: 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.1 0.0 0.0		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
ReportUtils [ReportUtils] getTransactionDetails on 1k reports function Baseline
Mean: 0.1 ms
Stdev: 0.0 ms (65.3%)
Runs: 0.1 0.1 0.0 0.1 0.0 0.0 0.0 0.1 0.1 0.0

Current
Mean: 0.1 ms
Stdev: 0.1 ms (79.7%)
Runs: 0.2 0.1 0.0 0.1 0.0 0.0 0.0 0.1 0.1 0.0		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
ReportUtils [ReportUtils] getWorkspaceChat on 1k policies function Baseline
Mean: 0.1 ms
Stdev: 0.0 ms (4.2%)
Runs: 0.2 0.2 0.1 0.1 0.2 0.1 0.1 0.1 0.1 0.1

Current
Mean: 0.2 ms
Stdev: 0.0 ms (4.8%)
Runs: 0.2 0.2 0.2 0.1 0.2 0.1 0.1 0.1 0.2 0.2		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
ReportUtils [ReportUtils] getWorkspaceIcon on 1k policies function Baseline
Mean: 0.0 ms
Stdev: 0.0 ms (84.8%)
Runs: 0.0 0.0 0.0 0.1 0.0 0.0 0.0 0.0 0.0 0.0

Current
Mean: 0.0 ms
Stdev: 0.0 ms (42.3%)
Runs: 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
ReportUtils [ReportUtils] shouldReportBeInOptionList on 1k participant function Baseline
Mean: 0.0 ms
Stdev: 0.0 ms (227.7%)
Runs: 0.0 0.0 0.0 0.0 0.1 0.0 0.0 0.0 0.0 0.0

Current
Mean: 0.0 ms
Stdev: 0.0 ms (70.7%)
Runs: 0.0 0.1 0.0 0.1 0.0 0.1 0.0 0.0 0.0 0.1		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
SidebarLinks [SidebarLinks] should click on list item render Baseline
Mean: 0.0 ms
Stdev: 0.0 ms (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0

Current
Mean: 0.0 ms
Stdev: 0.0 ms (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0		 Baseline
Mean: 9
Stdev: 0 (0.0%)
Runs: 9 9 9 9 9 9 9 9 9 9

Current
Mean: 9
Stdev: 0 (0.0%)
Runs: 9 9 9 9 9 9 9 9 9 9
SidebarLinks [SidebarLinks] should render Sidebar with 500 reports stored render Baseline
Mean: 0.0 ms
Stdev: 0.0 ms (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0

Current
Mean: 0.0 ms
Stdev: 0.0 ms (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0		 Baseline
Mean: 8
Stdev: 0 (0.0%)
Runs: 8 8 8 8 8 8 8 8 8 8

Current
Mean: 8
Stdev: 0 (0.0%)
Runs: 8 8 8 8 8 8 8 8 8 8
SidebarUtils [SidebarUtils] getOptionData function Baseline
Mean: 1.6 ms
Stdev: 0.8 ms (51.2%)
Runs: 1.8 1.2 1.2 1.2 1.4 1.3 1.2 1.4 3.8 1.2

Current
Mean: 1.5 ms
Stdev: 0.8 ms (53.3%)
Runs: 1.8 1.2 1.2 1.1 1.2 1.2 1.3 3.7 1.2 1.2		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
SidebarUtils [SidebarUtils] getOrderedReportIDs on 15k reports for GSD priorityMode function Baseline
Mean: 195.5 ms
Stdev: 1.5 ms (0.7%)
Runs: 195.5 195.3 194.2 194.3 193.5 194.5 198.3 196.7 196.8 195.8

Current
Mean: 192.2 ms
Stdev: 10.1 ms (5.3%)
Runs: 191.5 188.9 187.6 186.8 186.9 190.0 191.0 189.3 220.5 189.2		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Changes To Count

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

@fabioh8010 fabioh8010 changed the title [WIP] Skippable Collection Member IDs Skippable Collection Member IDs Jan 16, 2025
@fabioh8010 fabioh8010 marked this pull request as ready for review January 16, 2025 18:45
@fabioh8010 fabioh8010 requested a review from a team as a code owner January 16, 2025 18:45
@fabioh8010
Copy link
Contributor Author

PR opened to review!

@melvin-bot melvin-bot bot requested review from marcochavezf and removed request for a team January 16, 2025 18:45
@fabioh8010 fabioh8010 requested a review from VickyStash January 16, 2025 18:49
VickyStash
VickyStash reviewed Jan 17, 2025
View reviewed changes
lib/Onyx.ts Show resolved Hide resolved
lib/Onyx.ts
value = null;
}
} catch (e) {
// The key is not a collection one or something went wrong during split, so we proceed with the function's logic.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add console.error logging here so it's easier for the dev to get what went wrong.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add this try/catch because splitCollectionMemberKey is built in a way that will throw error mainly if the key passed is not a collection one. The problem with adding a console error is that it will spam the console very quickly as any normal key would trigger the catch flow, even if it's not "really" a problem.

lib/Onyx.ts Show resolved Hide resolved
lib/Onyx.ts
changes = undefined;
}
} catch (e) {
// The key is not a collection one or something went wrong during split, so we proceed with the function's logic.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, let's add console.error logging

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Answered here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VickyStash VickyStash VickyStash approved these changes

@marcochavezf marcochavezf Awaiting requested review from marcochavezf

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabioh8010 @VickyStash