Accept waypoint with marker component & add directionStyle prop
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this ready for review @hayata-suenaga? |
|
hey @thienlnam sorry for the late reply yep at least the code is ready for review I haven't tested this yet. I gonna test this in App this afternoon if I have time 👍 Update: I tested in this PR |
hayata-suenaga
changed the title
directionStyle propdirectionStyle prop
|
Great, thanks! |
thienlnam
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Make it possible to specify the style for the line used to display directions by adding
directionStyleprop toMapView.Related Issues
GH_LINK #19
Manual Tests
Test will be done in App PR that bumps the
react-native-x-mapsversion.Linked PRs
Expensify/App#25161
The above ⬆️ PR,
react-native-x-mapsinpackage.jsonpoints to the test branch I created. The test branch contains the same code as this PR but also has the transpiled code in thedistdirectory. The code is automatically transpiled and thedistdirectory is also automatically created when this PR is merged.After this PR is merged, the
package.jsonin the above PR should be updated to use the version number.