Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch in parameter count for esp8266 upload #125

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

CapnBry
Copy link
Member

@CapnBry CapnBry commented Dec 27, 2023

Build & Upload from VSCode throws this error on upload because... well because there's an error in the python? 😄

Looking for upload port...
Using manually specified: elrs_vrx.local
*** [upload] TypeError : do_upload() takes 4 positional arguments but 5 were given
Traceback (most recent call last):
Uploading .pio\build\Skyzone_SteadyView_ESP_RX_Backpack_via_WIFI\firmware.bin
  File "C:\Users\bmayland\.platformio\packages\tool-scons\scons-local-4.5.2\SCons\Action.py", line 1310, in execute
    result = self.execfunction(target=target, source=rsources, env=env)
  File "C:\Users\bmayland\Documents\GitHub Projects\ExpressLRS-Backpack\python\upload_via_esp8266_backpack.py", line 71, in on_upload
    do_upload(elrs_bin_target, pio_target, upload_addr, isstm, env)
TypeError: do_upload() takes 4 positional arguments but 5 were given

I dunno how this is working for anyone else flashing their backpack, I guess maybe the Configurator uses a different python file?

gzip firmware

Also, the firmware is too large to upload and needs to be gzipped, but the "buildprog" step does not appear to fire if uploading (only if "Build" is chosen first). That's ok, because the upload script also only will upload a bin, not a bin.gz. This PR also changes the build to be like the ELRS main firmware, adding a postbuild to the .bin file after the config is appended (the current code would also GZIP it before the config was added).

@CapnBry CapnBry merged commit 88ce11d into ExpressLRS:master Dec 28, 2023
29 checks passed
@CapnBry CapnBry deleted the backpack-gzip branch December 28, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants